Skip to content

Disable paging and raise pageSize on NinjaOne array-mode datastreams #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deenk wants to merge 1 commit into
base: main
Choose a base branch
from

Disable paging and raise pageSize on NinjaOne array-mode datastreams

f4363b3
Select commit
Loading
Failed to load commit list.
Open

Disable paging and raise pageSize on NinjaOne array-mode datastreams #52

Disable paging and raise pageSize on NinjaOne array-mode datastreams
f4363b3
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 28, 2026 in 3m 54s

Code review found 1 important issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important plugins/NinjaOne/v1/dataStreams/devices.json:8-10 Missing metadata.json version bump

Annotations

Check failure on line 10 in plugins/NinjaOne/v1/dataStreams/devices.json

See this annotation in the file changed.

@claude claude / Claude Code Review

Missing metadata.json version bump 

This PR modifies 6 data stream files under `plugins/NinjaOne/v1/dataStreams/` but does not bump the version in `plugins/NinjaOne/v1/metadata.json` (still at `1.1.9`). Per the repo's review guidance, any change inside a plugin directory must include a corresponding `metadata.json` version bump; since this is a behavior-affecting paging fix, please add at least a patch bump (e.g. `1.1.9` -> `1.1.10`) before merging.
View more details on Claude