Skip to content

PLUG-4654: Update Microsoft Defender Icon#60

Merged
jame2O merged 5 commits into
mainfrom
work/jd/PLUG-4654
Jun 18, 2026
Merged

PLUG-4654: Update Microsoft Defender Icon#60
jame2O merged 5 commits into
mainfrom
work/jd/PLUG-4654

Conversation

@jame2O

@jame2O jame2O commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

📋 Summary

This PR updates the icon for Microsoft Defender to an SVG. This fixes a bug where the icon was being cropped on squaredup.com

🔗 Related issue(s)

🧩 Plugin details

  • Plugin name:
  • Type of change:
    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo
    • Other (please describe):

⚠️ Breaking changes

Does this PR introduce any breaking changes?

  • No
  • Yes (please describe):

If yes, describe:

  • What breaks
  • Who is impacted
  • Any migration steps

📚 Documentation

  • Documentation updated
  • No documentation changes needed

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

@jame2O jame2O requested review from a team, masokisi and vinbab June 12, 2026 13:24
@jame2O jame2O added bug Something isn't working enhancement New feature or request labels Jun 12, 2026
clarkd
clarkd reviewed Jun 12, 2026
View reviewed changes
Comment thread plugins/MicrosoftDefender/v1/icon.svg Outdated
@clarkd

clarkd commented Jun 17, 2026

Copy link
Copy Markdown
Member

@claude review

clarkd
clarkd reviewed Jun 17, 2026
View reviewed changes
Comment thread plugins/MicrosoftDefender/v1/metadata.json Outdated
@clarkd

clarkd commented Jun 17, 2026

Copy link
Copy Markdown
Member

@claude review once

claude[bot]
claude Bot reviewed Jun 17, 2026
View reviewed changes
Comment thread plugins/MicrosoftDefender/v1/metadata.json Outdated
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/MicrosoftDefender/v1

📋 Results

Step Status
Validation ✅ Passed
Deployment 🚀 Deployed

🔍 Validation Details

✅ microsoft-defender 
{
  "valid": true,
  "pluginName": "microsoft-defender",
  "pluginType": "hybrid",
  "summary": {
    "Data Streams": 12,
    "Import Definitions": 1,
    "UI Configuration": true,
    "Has Icon": true,
    "Has Default Content": true,
    "Config Validation": true,
    "Custom Types": true
  }
}

claude[bot]
claude Bot reviewed Jun 18, 2026
View reviewed changes

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon swap with the requested 1.0.3 version bump — addresses the prior versioning feedback.

Extended reasoning...

Overview

This PR replaces plugins/MicrosoftDefender/v1/icon.png with icon.svg and bumps metadata.json from 1.0.0 to 1.0.3. Per the timeline, the reviewer (clarkd) requested 1.0.3 specifically to cover several previously-unbumped Defender plugin changes that landed on main, and the current diff now reflects that exact version.

Security risks

None. The change is purely a visual asset swap plus a version-number bump. No code paths, authentication, secrets, or data flow are touched.

Level of scrutiny

Low. This is a documentation/branding/metadata-only change: removing a PNG, adding an SVG (with a viewBox per the inline discussion), and bumping the plugin version. The previous reviewer feedback about the version was the only outstanding concern, and it has been addressed in the latest commit.

Other factors

The plugin validation/deployment check from the repo's CI summary passes. My prior bot review explicitly called out the 1.0.1 → 1.0.3 gap; the head of the branch now ships 1.0.3, so the unresolved comment is resolved by the code itself. No new code was introduced that would warrant deeper analysis.

@jame2O jame2O requested a review from vinbab June 18, 2026 07:20
@jame2O jame2O merged commit 1dd0a0f into main Jun 18, 2026
2 checks passed
@jame2O jame2O deleted the work/jd/PLUG-4654 branch June 18, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clarkd clarkd clarkd approved these changes

@claude claude[bot] claude[bot] left review comments

@vinbab vinbab vinbab approved these changes

@masokisi masokisi Awaiting requested review from masokisi

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature or request plugin: Microsoft Defender

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jame2O @clarkd @vinbab