Skip to content

PLUG-4654: Update Microsoft Defender Icon#60

Open
jame2O wants to merge 3 commits into
mainfrom
work/jd/PLUG-4654
Open

PLUG-4654: Update Microsoft Defender Icon#60
jame2O wants to merge 3 commits into
mainfrom
work/jd/PLUG-4654

Conversation

@jame2O

@jame2O jame2O commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

📋 Summary

This PR updates the icon for Microsoft Defender to an SVG. This fixes a bug where the icon was being cropped on squaredup.com

🔗 Related issue(s)

🧩 Plugin details

  • Plugin name:
  • Type of change:
    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo
    • Other (please describe):

⚠️ Breaking changes

Does this PR introduce any breaking changes?

  • No
  • Yes (please describe):

If yes, describe:

  • What breaks
  • Who is impacted
  • Any migration steps

📚 Documentation

  • Documentation updated
  • No documentation changes needed

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

@jame2O jame2O requested review from a team, masokisi and vinbab June 12, 2026 13:24
@jame2O jame2O added bug Something isn't working enhancement New feature or request labels Jun 12, 2026
clarkd
clarkd reviewed Jun 12, 2026
View reviewed changes
Comment thread plugins/MicrosoftDefender/v1/icon.svg Outdated
@@ -0,0 +1,68 @@
<svg width="30" height="30" viewBox="0 0 30 30" fill="none" xmlns="http://www.w3.org/2000/svg">

@clarkd clarkd Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to remove these fixed sizes for this to scale appropriately.

@jame2O jame2O Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Removing the fixed height, width and viewBox gives this weird scaling in-app. Most other LCP's have fixed sizing, will this definetly be an issue?

@clarkd clarkd Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the viewBox. Check some of the SVGs in the saas repo for comparison.

@jame2O jame2O Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/MicrosoftDefender/v1

📋 Results

Step Status
Validation ✅ Passed
Deployment 🚀 Deployed

🔍 Validation Details

✅ microsoft-defender 
{
  "valid": true,
  "pluginName": "microsoft-defender",
  "pluginType": "hybrid",
  "summary": {
    "Data Streams": 12,
    "Import Definitions": 1,
    "UI Configuration": true,
    "Has Icon": true,
    "Has Default Content": true,
    "Config Validation": true,
    "Custom Types": true
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clarkd clarkd clarkd left review comments

@masokisi masokisi Awaiting requested review from masokisi

@vinbab vinbab Awaiting requested review from vinbab

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature or request plugin: Microsoft Defender

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jame2O @clarkd