Skip to content

New Dashboard Ordering Resource that Includes Support for Dashboard Folders#132

Merged
shaswot77 merged 6 commits into
mainfrom
work/ss/dashboard-ordering
May 23, 2025
Merged

New Dashboard Ordering Resource that Includes Support for Dashboard Folders#132
shaswot77 merged 6 commits into
mainfrom
work/ss/dashboard-ordering

Conversation

@shaswot77
Copy link
Copy Markdown
Contributor

Description

  • Support for Dashboard Ordering which includes support for dashboard folders

Checklist:

  • Added a label: bug-fix, feature, or enhancement
  • PR description written

@shaswot77 shaswot77 requested a review from Copilot May 7, 2025 15:36
@shaswot77 shaswot77 added the enhancement New feature or request label May 7, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new dashboard ordering resource with support for dashboard folders to manage the ordering of dashboards within a workspace.

  • Adds acceptance tests for the new resource.
  • Implements CRUD operations and import functionality in the provider.
  • Updates documentation and examples to reflect the new resource usage.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/provider/resource_dashboard_ordering_test.go Implements acceptance tests including create, update, and import.
internal/provider/resource_dashboard_ordering.go Implements CRUD operations and state management for dashboard ordering.
internal/provider/provider.go Registers the new dashboard ordering resource.
internal/provider/models.go Extends workspace properties to include dashboard ordering.
examples/resources/squaredup_dashboard_ordering/resource.tf Provides example configuration for dashboard ordering.
examples/resources/squaredup_dashboard_ordering/import.sh Provides import instructions for the new resource.
docs/resources/dashboard_ordering.md Documents resource usage and schema details.
Comments suppressed due to low confidence (1)

internal/provider/resource_dashboard_ordering.go:31

  • [nitpick] The struct field 'DashboardIdOrder' is mapped to the schema attribute 'order'. Consider renaming it to 'Order' for consistency and clarity with the configured attribute name.
type squaredupDashboardOrdering struct {

Comment thread internal/provider/resource_dashboard_ordering.go
@shaswot77 shaswot77 requested review from clarkd and skatary-perso May 7, 2025 15:43
Comment thread docs/resources/dashboard_ordering.md Outdated
Comment thread docs/resources/dashboard_ordering.md Outdated
Comment thread docs/resources/dashboard_ordering.md
Comment thread docs/resources/dashboard_ordering.md Outdated
Comment thread internal/provider/resource_dashboard_ordering.go Outdated
Comment thread internal/provider/resource_dashboard_ordering.go Outdated
@shaswot77 shaswot77 force-pushed the work/ss/dashboard-ordering branch from 9f222c4 to 288b4c9 Compare May 19, 2025 08:55
@shaswot77 shaswot77 requested a review from clarkd May 19, 2025 09:01
@shaswot77 shaswot77 force-pushed the work/ss/dashboard-ordering branch from fe85f95 to 8516a83 Compare May 23, 2025 11:48
@shaswot77 shaswot77 merged commit c23d391 into main May 23, 2025
8 checks passed
@shaswot77 shaswot77 deleted the work/ss/dashboard-ordering branch May 23, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

3 participants