New Dashboard Ordering Resource that Includes Support for Dashboard Folders#132
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new dashboard ordering resource with support for dashboard folders to manage the ordering of dashboards within a workspace.
- Adds acceptance tests for the new resource.
- Implements CRUD operations and import functionality in the provider.
- Updates documentation and examples to reflect the new resource usage.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/provider/resource_dashboard_ordering_test.go | Implements acceptance tests including create, update, and import. |
| internal/provider/resource_dashboard_ordering.go | Implements CRUD operations and state management for dashboard ordering. |
| internal/provider/provider.go | Registers the new dashboard ordering resource. |
| internal/provider/models.go | Extends workspace properties to include dashboard ordering. |
| examples/resources/squaredup_dashboard_ordering/resource.tf | Provides example configuration for dashboard ordering. |
| examples/resources/squaredup_dashboard_ordering/import.sh | Provides import instructions for the new resource. |
| docs/resources/dashboard_ordering.md | Documents resource usage and schema details. |
Comments suppressed due to low confidence (1)
internal/provider/resource_dashboard_ordering.go:31
- [nitpick] The struct field 'DashboardIdOrder' is mapped to the schema attribute 'order'. Consider renaming it to 'Order' for consistency and clarity with the configured attribute name.
type squaredupDashboardOrdering struct {
clarkd
reviewed
May 8, 2025
9f222c4 to
288b4c9
Compare
clarkd
approved these changes
May 23, 2025
Co-Authored-By: Dave Clarke <3793131+clarkd@users.noreply.github.com>
fe85f95 to
8516a83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
bug-fix,feature, orenhancement