Skip to content

Commit 9eae799

Browse files
committed
feat: change default domain to devic.es
This commit puts discovered devices under a more neutral domain `devic.es`, which is a better default for most users. This is a breaking change for the default manifests and so needed to be released after a stable tag was released so users could pin to it easily. Fixes #75
1 parent ca22135 commit 9eae799

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Now, Pods that require a video capture device, such as an object detection servi
2222
```yaml
2323
resources:
2424
limits:
25-
squat.ai/video: 1
25+
devic.es/video: 1
2626
```
2727
2828
The `--device` flag can be provided multiple times to allow the plugin to discover and allocate different types of resources.
@@ -61,7 +61,7 @@ spec:
6161
name: http
6262
resources:
6363
limits:
64-
squat.ai/video: 1
64+
devic.es/video: 1
6565
EOF
6666
```
6767

@@ -98,7 +98,7 @@ Usage of generic-device-plugin:
9898
For example, to expose serial devices that may or may not be present: {"name": "serial", "groups": [{"paths": [{"path": "/dev/ttyS0", "optional": true}, {"path": "/dev/ttyUSB0", "optional": true}]}]}
9999
If mountPath is a directory, the device will be mounted to the directory with the name of the device.
100100
For example, to expose the serial devices to the /dev/serial directory: {"name": "serial", "groups": [{"paths": [{"path": "/dev/ttyUSB*", "mountPath": "/dev/serial/"}]}]}
101-
--domain string The domain to use when when declaring devices. (default "squat.ai")
101+
--domain string The domain to use when when declaring devices. (default "devic.es")
102102
--listen string The address at which to listen for health and metrics. (default ":8080")
103103
--log-level string Log level to use. Possible values: all, debug, info, warn, error, none (default "info")
104104
--plugin-directory string The directory in which to create plugin sockets. (default "/var/lib/kubelet/device-plugins/")

config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import (
2727
"github.com/squat/generic-device-plugin/deviceplugin"
2828
)
2929

30-
const defaultDomain = "squat.ai"
30+
const defaultDomain = "devic.es"
3131

3232
// initConfig defines config flags, config file, and envs
3333
func initConfig() error {

e2e_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func TestE2EBasic(t *testing.T) {
5555
testutil.Ok(t, err, string(out))
5656
out, err = kubectl(context.Background(), e, "rollout", "status", "daemonset", "generic-device-plugin", "--namespace", "kube-system").CombinedOutput()
5757
testutil.Ok(t, err, string(out))
58-
out, err = kubectl(context.Background(), e, "patch", "deployment", "fuse", "--patch", `{"spec": {"template": {"spec": {"containers": [{"name": "fuse", "resources": {"limits": {"squat.ai/fuse": 1}}}]}}}}`).CombinedOutput()
58+
out, err = kubectl(context.Background(), e, "patch", "deployment", "fuse", "--patch", `{"spec": {"template": {"spec": {"containers": [{"name": "fuse", "resources": {"limits": {"devic.es/fuse": 1}}}]}}}}`).CombinedOutput()
5959
testutil.Ok(t, err, string(out))
6060
out, err = kubectl(context.Background(), e, "rollout", "status", "deployment", "fuse").CombinedOutput()
6161
testutil.Ok(t, err, string(out))

0 commit comments

Comments
 (0)