Skip to content

Commit d660d1f

Browse files
authored
Merge pull request #216 from inistor/fix/duplicate-label-render
Remove duplicate `app.kubernetes.io/name` label from rendered manifests
2 parents 341c81c + aca9ed9 commit d660d1f

4 files changed

Lines changed: 2 additions & 5 deletions

File tree

charts/generic-device-plugin/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ type: application
1313
# This is the chart version. This version number should be incremented each time you make changes
1414
# to the chart and its templates, including the app version.
1515
# Versions are expected to follow Semantic Versioning (https://semver.org/)
16-
version: 0.1.1
16+
version: 0.1.2
1717
# This is the version number of the application being deployed. This version number should be
1818
# incremented each time you make changes to the application. Versions are not expected to
1919
# follow Semantic Versioning. They should reflect the version the application is using.

charts/generic-device-plugin/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# generic-device-plugin
22

3-
![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.2.0](https://img.shields.io/badge/AppVersion-0.2.0-informational?style=flat-square)
3+
![Version: 0.1.2](https://img.shields.io/badge/Version-0.1.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.2.0](https://img.shields.io/badge/AppVersion-0.2.0-informational?style=flat-square)
44

55
A Helm chart for deploying the generic-device-plugin on Kubernetes
66

charts/generic-device-plugin/templates/daemonset.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ metadata:
44
name: {{ include "generic-device-plugin.fullname" . }}
55
namespace: kube-system
66
labels:
7-
app.kubernetes.io/name: generic-device-plugin
87
{{- include "generic-device-plugin.labels" . | nindent 4 }}
98
spec:
109
selector:
@@ -17,7 +16,6 @@ spec:
1716
{{- toYaml . | nindent 8 }}
1817
{{- end }}
1918
labels:
20-
app.kubernetes.io/name: generic-device-plugin
2119
{{- include "generic-device-plugin.labels" . | nindent 8 }}
2220
{{- with .Values.podLabels }}
2321
{{- toYaml . | nindent 8 }}

charts/generic-device-plugin/templates/podmonitor.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ apiVersion: monitoring.coreos.com/v1
33
kind: PodMonitor
44
metadata:
55
labels:
6-
app.kubernetes.io/name: generic-device-plugin
76
{{- include "generic-device-plugin.labels" . | nindent 4 }}
87
name: {{ include "generic-device-plugin.fullname" . }}
98
namespace: kube-system

0 commit comments

Comments
 (0)