Remove always-zero CacheDigestGuessStats::closeHits (#2062)

rousskov · squid-anubis · commit 19127eee52f6 · 2025-05-18T07:58:56.000Z
The data member stopped being updated in 1998 commit 69c95dd. It was scheduled for removal since inception in 1998 commit 04f0c41.
diff --git a/src/CacheDigest.cc b/src/CacheDigest.cc
@@ -237,8 +237,6 @@ cacheDigestGuessStatsReport(const CacheDigestGuessStats * stats, StoreEntry * se
                       hit_count, xpercent(hit_count, tot_count),
                       miss_count, xpercent(miss_count, tot_count),
                       tot_count, xpercent(tot_count, tot_count));
-    storeAppendPrintf(sentry, "\tclose_hits: %d ( %d%%) /* cd said hit, doc was in the peer cache, but we got a miss */\n",
-                      stats->closeHits, xpercentInt(stats->closeHits, stats->falseHits));
 }
 
 void
diff --git a/src/StatCounters.h b/src/StatCounters.h
@@ -22,7 +22,6 @@ class CacheDigestGuessStats
     int falseHits = 0;
     int trueMisses = 0;
     int falseMisses = 0;
-    int closeHits = 0;     // TODO: temporary. remove it later
 };
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -237,8 +237,6 @@ cacheDigestGuessStatsReport(const CacheDigestGuessStats * stats, StoreEntry * se`
`237`	`237`	`hit_count, xpercent(hit_count, tot_count),`
`238`	`238`	`miss_count, xpercent(miss_count, tot_count),`
`239`	`239`	`tot_count, xpercent(tot_count, tot_count));`
`240`		`- storeAppendPrintf(sentry, "\tclose_hits: %d ( %d%%) /* cd said hit, doc was in the peer cache, but we got a miss */\n",`
`241`		`- stats->closeHits, xpercentInt(stats->closeHits, stats->falseHits));`
`242`	`240`	`}`
`243`	`241`
`244`	`242`	`void`