Maintenance: Remove shared LDADD#2058
Closed
yadij wants to merge 4 commits into
Closed
Conversation
Binaries in Squid each have a distinct set of dependencies and thus their own foo_LDADD variables. Stop setting an (incomplete) LDADD for shared use in Makefile.am.
rousskov
approved these changes
May 6, 2025
rousskov
left a comment
rousskov
left a comment
Contributor
There was a problem hiding this comment.
I have adjusted PR description a little to be in sync with PR changes that set (the same) foo_LDADD dependencies for a few binaries (e.g., syntheticoperators and VirtualDeleteOperator). The original description implied that such binaries did not exist; they do exist, but they are an exception that does not justify LDADD global existence.
I also tried to disclose and explain a seemingly out-of-scope change -- EXTRA_PROGRAMS removal.
I am not clearing this PR for merging to give @yadij a chance to validate my description adjustments.
rousskov
added
the
S-waiting-for-author
squid-anubis
pushed a commit
that referenced
this pull request
May 6, 2025
Most built binaries have a distinct set of dependencies and already have their own foo_LDADD variables. Add a few variables to cover the remaining binaries and stop setting an (incomplete) LDADD global. Also removed unnecessary EXTRA_PROGRAMS because mem_node_test and splay binaries are built unconditionally.
squid-anubis
added
M-waiting-staging-checks
Contributor
@kinkie, can you help address the above OpenBSD test failure? AFAICT, Anubis will not merge PRs until that problem is gone. |
yadij
added
M-cleared-for-merge
Merged
Contributor
PR #2059 should fix it |
rousskov
added
the
S-waiting-for-PR
squid-anubis
added
M-failed-other
kinkie
added
backport-to-v7
squid-anubis
pushed a commit
that referenced
this pull request
May 11, 2025
Most built binaries have a distinct set of dependencies and already have their own foo_LDADD variables. Add a few variables to cover the remaining binaries and stop setting an (incomplete) LDADD global. Also removed unnecessary EXTRA_PROGRAMS because mem_node_test and splay binaries are built unconditionally.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-abandoned-staging-checks
rousskov
removed
the
S-waiting-for-PR
squid-anubis
pushed a commit
that referenced
this pull request
May 18, 2025
Most built binaries have a distinct set of dependencies and already have their own foo_LDADD variables. Add a few variables to cover the remaining binaries and stop setting an (incomplete) LDADD global. Also removed unnecessary EXTRA_PROGRAMS because mem_node_test and splay binaries are built unconditionally.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
removed
the
M-waiting-staging-checks
squid-anubis
added
M-merged
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
May 18, 2025
Most built binaries have a distinct set of dependencies and already have their own foo_LDADD variables. Add a few variables to cover the remaining binaries and stop setting an (incomplete) LDADD global. Also removed unnecessary EXTRA_PROGRAMS because mem_node_test and splay binaries are built unconditionally.
squidadm
removed
the
backport-to-v7
Collaborator
|
queued for backport to v7 |
yadij
added a commit
that referenced
this pull request
May 19, 2025
Most built binaries have a distinct set of dependencies and already have their own foo_LDADD variables. Add a few variables to cover the remaining binaries and stop setting an (incomplete) LDADD global. Also removed unnecessary EXTRA_PROGRAMS because mem_node_test and splay binaries are built unconditionally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most built binaries have a distinct set of dependencies and already have
their own foo_LDADD variables. Add a few variables to cover the
remaining binaries and stop setting an (incomplete) LDADD global.
Also removed unnecessary EXTRA_PROGRAMS because mem_node_test and splay
binaries are built unconditionally.