Skip to content

Remove SGI IRIX support#2404

Closed
kinkie wants to merge 7 commits intosquid-cache:masterfrom
kinkie:deprecate-irix
Closed

Remove SGI IRIX support#2404
kinkie wants to merge 7 commits intosquid-cache:masterfrom
kinkie:deprecate-irix

Conversation

@kinkie
Copy link
Copy Markdown
Contributor

@kinkie kinkie commented Apr 10, 2026

SGI IRIX was last released in 2006, and
support discontinued in 2013.

kinkie added 2 commits April 9, 2026 22:17
@kinkie
Remove SCO OpenServer support
8974a39 
SCO OpenServer was EOL'd in 2023.
Users wishing to build for this OS can use build time options:
 ./configure CFLAGS="-lintl"
@kinkie
Remove support for IRIX
77ad8af
yadij
yadij previously approved these changes Apr 11, 2026
View reviewed changes
@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels feature maintainer needs documentation updates for merge S-could-use-an-approval An approval may speed this PR merger (but is not required) backport-to-v7 maintainer has approved these changes for v7 backporting labels Apr 11, 2026
@rousskov rousskov self-requested a review April 11, 2026 10:49
@rousskov rousskov changed the title Remove IRIX support Remove SGI IRIX support Apr 13, 2026
rousskov
rousskov previously requested changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support removing official SGI IRIX support and associated code hacks.

This PR leaves IRIX-specific code in tools/sysvinit/squid.rc. Please drop that code or adjust its description to become more general. This is not my area of expertise, but googling suggests that generalizing that comment may be more appropriate here, with an updated comment saying something like "Many older Linux distributions that use System V".

Please remove a mention of IRIX use case from compat/fdsetsize.h. For example, the updated comment can say "On some systems (e.g., NetBSD), FD_SETSIZE ...".

Please remove install-irix6.2 target from contrib/Makefile.am.

I added "SGI" to the PR title to provide more context for "IRIX".

@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Apr 13, 2026
@kinkie
Copy link
Copy Markdown
Contributor Author

kinkie commented Apr 18, 2026

Removed all references. Only ChangeLog and SNMP releasenotes remain

@kinkie kinkie requested a review from rousskov April 18, 2026 21:58
@kinkie kinkie added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels and removed S-waiting-for-author author action is expected (and usually required) labels Apr 18, 2026
@rousskov rousskov dismissed their stale review April 19, 2026 13:33

Thank you for addressing my concerns.

I am not approving this PR because I am concerned about rc changes going too far (as discussed in my change request), but I am no longer blocking it either. Your call.

@rousskov rousskov removed their request for review April 19, 2026 13:33
@squid-anubis squid-anubis added M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels and removed M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels labels Apr 19, 2026
squid-anubis pushed a commit that referenced this pull request Apr 20, 2026
@kinkie @squid-anubis
Remove SGI IRIX support (#2404)
60179f3 
SGI IRIX was last released in 2006, and
support discontinued in 2013.
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-failed-staging-other https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Apr 20, 2026
yadij
yadij approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@yadij yadij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If there is anyone actually using Squid on such an "old *nix" the change can be added back when the change is tested properly.

@yadij yadij removed the S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box label Apr 21, 2026
@kinkie kinkie removed the M-failed-staging-other https://github.com/measurement-factory/anubis#pull-request-labels label Apr 25, 2026
squid-anubis pushed a commit that referenced this pull request Apr 25, 2026
@kinkie @squid-anubis
Remove SGI IRIX support (#2404)
0cd72c3 
SGI IRIX was last released in 2006, and
support discontinued in 2013.
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Apr 25, 2026
@kinkie
Copy link
Copy Markdown
Contributor Author

kinkie commented Apr 25, 2026

Staging tests are failing in FreeBSD due to deskflow/deskflow#9691 .

@rousskov
Copy link
Copy Markdown
Contributor

rousskov commented Apr 26, 2026

Staging tests are failing in FreeBSD due to deskflow/deskflow#9691 .

Do we need to do anything to get their fix? We could force-merge this PR now, but since this FreeBSD CI problem is going to bite the next PR anyway, it probably does not make sense to do so.

@yadij
Copy link
Copy Markdown
Contributor

yadij commented Apr 26, 2026 •
edited
Loading

Their fix is to pin the "release:" tag to 14.4. We already build with 14.3 and 13.5 stables.
The issues is the newer 15.0 version. To "get their fix" we just have to stop testing on that newer version.

As they mention the long-term problem is that the issue affects FreeBSD users trying to build our software. IMO the fix should go in with a release note saying that issues are known on FreeBSD 15.

@squid-anubis squid-anubis added the M-abandoned-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Apr 27, 2026
@yadij yadij removed M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-abandoned-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Apr 27, 2026
squid-anubis pushed a commit that referenced this pull request Apr 27, 2026
@kinkie @squid-anubis
Remove SGI IRIX support (#2404)
f6cc033 
SGI IRIX was last released in 2006, and
support discontinued in 2013.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Apr 27, 2026
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Apr 27, 2026
@squidadm squidadm removed the backport-to-v7 maintainer has approved these changes for v7 backporting label Apr 27, 2026
@squidadm
Copy link
Copy Markdown
Collaborator

squidadm commented Apr 27, 2026

queued for backport to v7

kinkie added a commit that referenced this pull request Apr 27, 2026
@kinkie
Remove SGI IRIX support (#2404)
4e9a397 
SGI IRIX was last released in 2006, and
support discontinued in 2013.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadij yadij yadij approved these changes

@rousskov rousskov rousskov left review comments

Assignees

No one assigned

Labels

feature maintainer needs documentation updates for merge M-merged https://github.com/measurement-factory/anubis#pull-request-labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kinkie @rousskov @yadij @squidadm @squid-anubis