Fix handling of truncated legacy errorpage %codes (#2411)#2412
Merged
kinkie merged 1 commit intosquid-cache:v7from Apr 25, 2026
Merged
Fix handling of truncated legacy errorpage %codes (#2411)#2412kinkie merged 1 commit intosquid-cache:v7from
kinkie merged 1 commit intosquid-cache:v7from
Conversation
When build.input ends with a bare percent character, we must only copy/consume that character and increment build.input by 1, not 2. This overread bug existed since errorpage templates were introduced in 1997 commit 9b312a1. 2010 commit 4d16918 significantly broadened the kinds of use cases that can trigger this bug.
kinkie
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When build.input ends with a bare percent character, we must only
copy/consume that character and increment build.input by 1, not 2.
This overread bug existed since errorpage templates were introduced in
1997 commit 9b312a1. 2010 commit 4d16918 significantly broadened the
kinds of use cases that can trigger this bug.