Skip to content

Commit 1fe5221

Browse files
committed
Drop deftest- — not in cljs.test
Mirror squint: deftest- isn't part of cljs.test, only clojure.test. Drop it from the public surface and remove the test that exercised it. Bumps squint sha.
1 parent 5a76ca3 commit 1fe5221

3 files changed

Lines changed: 3 additions & 15 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
aliases for now and may be deprecated in a future version.
88
- Multiple `:require-macros` clauses with `:refer` now properly accumulate instead of overwriting each other
99
- Add `cherry.test` with `clojure.test`-compatible testing API: `deftest`,
10-
`is`, `testing`, `are`, `deftest-`, `use-fixtures`, `async`, `run-tests`
10+
`is`, `testing`, `are`, `use-fixtures`, `async`, `run-tests`
1111
(no-args defaults to current ns; also accepts quoted ns symbols). Macros
1212
are compiler built-ins (shared with squint) — no `:require-macros`
1313
plumbing needed in user code. Per-namespace fixtures, counter isolation

deps.edn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
org.babashka/sci {:mvn/version "0.10.49"}
44
io.github.squint-cljs/squint
55
#_{:local/root "/Users/borkdude/dev/squint"}
6-
{:git/sha "362e123e9161704a42469b82ffae099f53403ede"}}
6+
{:git/sha "9ad6e7b6106c93fd58cd3c1358d5838cce85db28"}}
77
:aliases
88
{:cljs {:extra-paths ["test"]
99
:extra-deps {thheller/shadow-cljs {:mvn/version "3.3.4"}

test/cherry/cross_platform_test.cljc

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
(ns cherry.cross-platform-test
22
(:require [clojure.test :as t #?@(:clj [:refer [deftest is testing are]])]
33
[clojure.string :as str])
4-
#?(:cljs (:require-macros [clojure.test :as t :refer [deftest deftest- is testing are async]])))
4+
#?(:cljs (:require-macros [clojure.test :as t :refer [deftest is testing are async]])))
55

66
(defonce test-db (atom nil))
77

@@ -362,17 +362,6 @@
362362
(is (= [:setup :test-done :teardown] @log)
363363
"teardown should wait for async test")))))
364364

365-
#?(:cljs
366-
(deftest- ^:async private-async-helper
367-
(await (js/Promise. (fn [resolve] (js/setTimeout resolve 5))))
368-
(is true)))
369-
370-
#?(:cljs
371-
(deftest deftest-private-async-test
372-
(testing "deftest- works with ^:async"
373-
(let [result (t/test-var private-async-helper)]
374-
(is (instance? js/Promise result) "deftest- ^:async returns Promise")))))
375-
376365
#?(:cljs
377366
(deftest ^:async run-tests-async-test
378367
(testing "run-tests chains async tests correctly"
@@ -435,7 +424,6 @@
435424
(t/test-var successful-test)
436425
(t/test-var test-var-counter-test)
437426
(await (t/test-var wrap-async-fixture-test))
438-
(t/test-var deftest-private-async-test)
439427
(await (t/test-var run-tests-async-test))
440428
(t/test-var per-ns-each-fixtures-test)
441429
(t/test-var per-ns-once-fixtures-test)

0 commit comments

Comments
 (0)