Avoid incompatibility between Generic and PSR2 standards for function call indentation

[fredden]

Generic.WhiteSpace.ScopeIndent and PSR2.Methods.FunctionCallSignature both try to fix indentation differently. This results in files not being able to be fixed automatically with phpcbf.

See #2078 (comment) where @gsherwood says that Generic.WhiteSpace.ScopeIndent should win in these cases.

This pull request fixes #2078 by eliminating the incompatibility when both sniffs are being run. When Generic.WhiteSpace.ScopeIndent is not active, then PSR2.Methods.FunctionCallSignature will continue to work as normal. When Generic.WhiteSpace.ScopeIndent is active, then this particular code-path will be ignored/skipped.

[jrfnl]

1. Do you have a code sample demonstrating the conflict ?
2. Could that code sample be added to the test file ?
3. As for referencing another sniff via a hard-coded name to avoid conflicts: that's generally not the way to solve these type of issues.

[fredden]

1. Do you have a code sample demonstrating the conflict ?

Yes, see #2078 (comment).

2. Could that code sample be added to the test file ?

I've been working on this, and it's difficult. I expect to update the pull request with this soon.

3. As for referencing another sniff via a hard-coded name to avoid conflicts: that's generally not the way to solve these type of issues.

I agree. Can you suggest a viable alternative in this case?

[fredden]

@jrfnl I've revisited this and written something completely different to the first attempt. I don't seem to be able to request your review via the GitHub web interface. Please can you take a look at this and let me know what you think.

I'm not particularly happy with the use of strpos() to detect the standard name. Do you have any suggestions for fixing this?
Edit: I've fixed this in 58512dc.

[fredden]

Superseded by PHPCSStandards/PHP_CodeSniffer#38