Skip to content

Config.php optimization avoid quadratic complexity with hashmap aka array in PHP ;) XD#3972

Closed
LLyaudet wants to merge 1 commit into
squizlabs:masterfrom
LLyaudet:patch-1
Closed

Config.php optimization avoid quadratic complexity with hashmap aka array in PHP ;) XD#3972
LLyaudet wants to merge 1 commit into
squizlabs:masterfrom
LLyaudet:patch-1

Conversation

@LLyaudet

@LLyaudet LLyaudet commented Mar 26, 2026

Copy link
Copy Markdown

Description

I want to avoid quadratic complexity and nested loops.

Suggested changelog entry

Asymptotic complexity optimization on standards loops.

Related issues/external references

Fixes #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement
  • Asymptotic optimization.

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • [not needed] I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.
  • [Required for new files] I have added any new files to the package.xml file.

@jrfnl

jrfnl commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Please don't open PRs in this repo anymore. This repo is abandoned and https://github.com/PHPCSStandards/PHP_CodeSniffer is its successor. See: #3932

@jrfnl jrfnl closed this Mar 26, 2026
@LLyaudet

Copy link
Copy Markdown
Author

Very strange. I was certain to be on the new repository when browsing code and found this. Probably yet another rewriting of what I do. I will check if the same optimization is possible on the other repository.

@LLyaudet

Copy link
Copy Markdown
Author

Another question: May I ask why there are still 52 PRs open on this repository then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants