TestSuiteHelper: Include felix.scr if osgi.component is required

Some test cases use 'org.eclipse.core.runtime' as dependency.

One of the runtime's dependencies (org.eclipse.core.contenttype)
uses declarative services to provide a service component, but was
missing the Require-Capability: header to require the
osgi.extender=osgi.component.

In eclipse-platform/eclipse.platform#2162
this was corrected.

But as a result, for the resolution of org.eclipse.core.runtime
to succeed, a OSGI extender provider must now strictly be present.

This cannot be auto-resolved by the PDE API tooling tests, as
these tests are quite special and the bundles available in the
resolver state are hand-picked by

    TestSuiteHelper.addAllRequired(IApiBaseline, Set<String>, IApiComponent, List<IApiComponent>)

which currently does not support this kind of dependency.

To work around that, we check if we find a dependency on SCR
and if so, add an implementation for it to the baseline fixture:
org.apache.felix.scr and its dependencies.

Author: sratz

apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/model/tests/TestSuiteHelper.java

@@ -35,6 +35,7 @@
 import org.eclipse.osgi.service.resolver.ResolverError;
 import org.eclipse.pde.api.tools.internal.model.ApiModelFactory;
 import org.eclipse.pde.api.tools.internal.model.ApiType;
+import org.eclipse.pde.api.tools.internal.model.BundleComponent;
 import org.eclipse.pde.api.tools.internal.provisional.IApiDescription;
 import org.eclipse.pde.api.tools.internal.provisional.IApiFilterStore;
 import org.eclipse.pde.api.tools.internal.provisional.IRequiredComponentDescription;
@@ -51,6 +52,8 @@
 import org.eclipse.pde.api.tools.internal.util.Util;
 import org.junit.Assert;
 import org.osgi.framework.Bundle;
+import org.osgi.framework.Constants;
+import org.osgi.framework.wiring.BundleRequirement;
 
 /**
  * Helper methods to set up baselines, etc.
@@ -412,6 +415,30 @@ public static File getBundle(String bundleName) {
 	 */
 	public static void addAllRequired(IApiBaseline baseline, Set<String> done, IApiComponent component, List<IApiComponent> collection) throws CoreException {
 		IRequiredComponentDescription[] descriptions = component.getRequiredComponents();
+		if (component instanceof BundleComponent bc) {
+			for (BundleRequirement extenderRequirements : bc.getBundleDescription()
+					.getDeclaredRequirements("osgi.extender")) { //$NON-NLS-1$
+				if (extenderRequirements.getDirectives().get(Constants.FILTER_DIRECTIVE)
+						.matches(".*osgi.extender\\s*=\\s*osgi.component.*")) { //$NON-NLS-1$
+					if (!done.contains("org.apache.felix.scr")) { //$NON-NLS-1$
+						List<String> scrAndDependencies = List.of("org.apache.felix.scr", "org.osgi.service.event", //$NON-NLS-1$ //$NON-NLS-2$
+								"org.osgi.service.component", "org.osgi.util.promise", "org.osgi.util.function"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
+						for (String scrBundleId : scrAndDependencies) {
+							File scrBundle = getBundle(scrBundleId);
+							if (scrBundle != null) {
+								IApiComponent scrComponent = ApiModelFactory.newApiComponent(baseline,
+										scrBundle.getAbsolutePath());
+								if (scrComponent != null) {
+									collection.add(scrComponent);
+									done.add(scrComponent.getSymbolicName());
+								}
+							}
+						}
+
+					}
+				}
+			}
+		}
 		boolean error = false;
 		StringBuilder buffer = null;
 		for (IRequiredComponentDescription description : descriptions) {