feat: add minimal Turborepo setup#633
Draft
anthonyshew wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/backend/package.json">
<violation number="1" location="apps/backend/package.json:8">
P2: Backend lint script is a no-op placeholder, so monorepo linting will pass without linting the backend.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "scripts": { | ||
| "dev": "uv run uvicorn app.main:app --reload --host 0.0.0.0 --port 8000", | ||
| "build": "echo 'No build step for Python backend'", | ||
| "lint": "echo 'Use ruff or pylint directly'", |
Contributor
There was a problem hiding this comment.
P2: Backend lint script is a no-op placeholder, so monorepo linting will pass without linting the backend.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/backend/package.json, line 8:
<comment>Backend lint script is a no-op placeholder, so monorepo linting will pass without linting the backend.</comment>
<file context>
@@ -0,0 +1,11 @@
+ "scripts": {
+ "dev": "uv run uvicorn app.main:app --reload --host 0.0.0.0 --port 8000",
+ "build": "echo 'No build step for Python backend'",
+ "lint": "echo 'Use ruff or pylint directly'",
+ "test": "uv run pytest"
+ }
</file context>
Owner
|
Hey @anthonyshew I'm using npm on this project right now. Also, right now, there's another PR that fixes some issues on the front-end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a starting point. The Turborepo configuration is correct, but some package scripts need fixes (the issues are easily visible when running tasks like
pnpm lintorpnpm test).Summary
apps/frontendandapps/backendFiles Added
package.jsonpnpm-workspace.yamlturbo.jsonapps/backend/package.jsonuvpnpm-lock.yamlAvailable Commands
AI usage
Chat transcript: https://opncd.ai/share/sRUNDbK0
Summary by cubic
Adds a minimal Turborepo setup with pnpm workspaces to orchestrate tasks across frontend and backend. Lets you run, build, lint, and test apps together with parallel execution and shared caching.
New Features
Migration
Written for commit 84a34c0. Summary will update on new commits.