fix(builder): allow Enter key to create new lines in Additional Info textareas (#763)#788
Open
Frankli9986 wants to merge 8 commits into
Open
fix(builder): allow Enter key to create new lines in Additional Info textareas (#763)#788Frankli9986 wants to merge 8 commits into
Frankli9986 wants to merge 8 commits into
Conversation
Add Groq as a supported LLM provider across the full stack. Backend: - config.py: add groq to llm_provider Literal and provider_map - llm.py: add groq/ prefix mapping, known prefix, key map, and timeout factor - routers/config.py: add groq to SUPPORTED_PROVIDERS and API key update handler - schemas/models.py: add groq field to ApiKeysUpdateRequest Frontend: - lib/api/config.ts: add groq to LLMProvider, PROVIDER_INFO, ApiKeyProvider, ApiKeysUpdateRequest, and API_KEY_PROVIDER_INFO - settings/page.tsx: add groq to PROVIDERS array
Contributor
There was a problem hiding this comment.
3 issues found across 11 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/frontend/components/resume/resume-two-column.tsx">
<violation number="1" location="apps/frontend/components/resume/resume-two-column.tsx:422">
P2: Section visibility checks use unfiltered array length, so whitespace-only additional fields can render empty sections with a title but no content</violation>
</file>
<file name="apps/frontend/components/resume/resume-single-column.tsx">
<violation number="1" location="apps/frontend/components/resume/resume-single-column.tsx:397">
P2: Whitespace-only additional items can still pass the raw length checks, so the section/rows render even though the joined display text is empty.</violation>
</file>
<file name="apps/backend/app/llm.py">
<violation number="1" location="apps/backend/app/llm.py:920">
P2: Removing DeepSeek's timeout multiplier regresses a supported provider by lowering its timeout budget from 1.3x to the default 1.0x, which can cause avoidable request timeouts.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Filter whitespace-only items in section visibility checks (two-column & single-column) - Restore deepseek 1.3x timeout multiplier in llm.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#763
Description
Fixes a bug where pressing Enter in Additional Info textareas (Technical Skills, Languages, Certifications, Awards) would not create a new line. The root cause was
handleArrayChangeimmediately filtering out empty strings with.filter((item) => item.trim() !== ''), which caused the textarea value to be overwritten on every input event — effectively undoing the Enter keystroke.The fix removes the input-time filtering and moves it to the renderer level in all 4 resume templates, ensuring empty lines are preserved during editing while empty strings are filtered out when rendering the final resume.
Type
Proposed Changes
apps/frontend/components/builder/forms/additional-form.tsx.filter((item) => item.trim() !== '')fromhandleArrayChangeapps/frontend/components/resume/resume-single-column.tsx.filter((s) => s.trim())before.join(', ')fortechnicalSkills,languages,certificationsTraining,awardsapps/frontend/components/resume/resume-modern.tsxapps/frontend/components/resume/resume-two-column.tsx.filter((s) => s.trim())before.map()/.join(' • ')for all 4 additional fieldsapps/frontend/components/resume/resume-modern-two-column.tsxHow to Test
Checklist
Summary by cubic
Adds
groqas a supported LLM provider and fixes Enter key handling in Additional Info textareas so new lines work. Fixes #763.New Features
groqprovider across backend and frontend (config, API key management, settings UI).groqmodel set tollama-3.3-70b-versatile.Bug Fixes
technicalSkills,languages,certificationsTraining,awards, and in section visibility checks (single- and two-column).deepseek1.3x timeout multiplier.Written for commit 44640df. Summary will update on new commits.