Job title to tailoring flow#798
Open
crazyscriptright wants to merge 3 commits into
Open
Conversation
Add optional job_title support end-to-end so users can target a specific role when tailoring resumes. Backend: Database.create_job now accepts and stores job_title; JobUploadRequest/Response schemas include job_title; routers pass job_title through upload and improve flows; _preserve_personal_info can override personalInfo.title with job_title_override and _validate_confirm_payload skips title comparison when an override is present; created resumes use the job_title (if provided) as the effective title. Frontend: tailor page adds a Job Title input and state, passes jobTitle to uploadJobDescriptions; API client sends job_title on upload. Also add localized labels/placeholders for the job title in multiple locales and add a workspace file to .gitignore.
Contributor
There was a problem hiding this comment.
1 issue found across 13 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/backend/app/routers/resumes.py">
<violation number="1" location="apps/backend/app/routers/resumes.py:853">
P1: Job title override can be lost after refinement because it is only applied before `refine_resume()` and never re-applied before persisting the tailored resume.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| @@ -362,10 +362,15 @@ def _protect_custom_sections( | |||
| def _preserve_personal_info( | |||
Contributor
There was a problem hiding this comment.
P1: Job title override can be lost after refinement because it is only applied before refine_resume() and never re-applied before persisting the tailored resume.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/backend/app/routers/resumes.py, line 853:
<comment>Job title override can be lost after refinement because it is only applied before `refine_resume()` and never re-applied before persisting the tailored resume.</comment>
<file context>
@@ -833,6 +850,7 @@ async def _improve_preview_flow(
improved_data, preserve_warnings = _preserve_personal_info(
original_resume_data,
improved_data,
+ job_title_override=job.get("job_title"),
)
response_warnings.extend(preserve_warnings)
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Job title feature
Description
added feature to add job title while creating resume
solved build errors for timeout and eslint issue
Type
Proposed Changes
How to Test
Checklist
Summary by cubic
Add an optional Job Title to the tailoring flow so users can target a specific role. The backend stores the title with the job and uses it to override the resume’s title during preview and when creating the tailored resume.
New Features
job_titleon job upload.create_jobnow acceptsjob_title; routers pass it through preview/confirm flows;_preserve_personal_infooverridespersonalInfo.titlewhen provided;_validate_confirm_payloadignores title differences when overridden; tailored resumes use the effective title.en,es,ja,pt-BR, andzh.Bug Fixes
Written for commit aae167b. Summary will update on new commits.