Skip to content

Job title to tailoring flow#798

Open
crazyscriptright wants to merge 3 commits into
srbhr:mainfrom
crazyscriptright:anil-reset
Open

Job title to tailoring flow#798
crazyscriptright wants to merge 3 commits into
srbhr:mainfrom
crazyscriptright:anil-reset

Conversation

@crazyscriptright
Copy link
Copy Markdown

@crazyscriptright crazyscriptright commented May 9, 2026

Pull Request Title

Job title feature

Description

added feature to add job title while creating resume
solved build errors for timeout and eslint issue

Type

  • Bug Fix
  • Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify):

Proposed Changes

  • tailoring flow

How to Test

  1. create new resume
  2. add job title (default is master resume jobtitle)
  3. click on generate resume

Checklist

  • The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • This pull request has been linked to the related issue (if applicable)

Summary by cubic

Add an optional Job Title to the tailoring flow so users can target a specific role. The backend stores the title with the job and uses it to override the resume’s title during preview and when creating the tailored resume.

  • New Features

    • Tailor page: added a Job Title input and sends job_title on job upload.
    • Backend: create_job now accepts job_title; routers pass it through preview/confirm flows; _preserve_personal_info overrides personalInfo.title when provided; _validate_confirm_payload ignores title differences when overridden; tailored resumes use the effective title.
    • i18n: added labels/placeholders for Job Title in en, es, ja, pt-BR, and zh.
  • Bug Fixes

    • Fixed ESLint/build errors.
    • Improved timeout error messaging and added localized timeout strings.

Written for commit aae167b. Summary will update on new commits.

Add optional job_title support end-to-end so users can target a specific role when tailoring resumes. Backend: Database.create_job now accepts and stores job_title; JobUploadRequest/Response schemas include job_title; routers pass job_title through upload and improve flows; _preserve_personal_info can override personalInfo.title with job_title_override and _validate_confirm_payload skips title comparison when an override is present; created resumes use the job_title (if provided) as the effective title. Frontend: tailor page adds a Job Title input and state, passes jobTitle to uploadJobDescriptions; API client sends job_title on upload. Also add localized labels/placeholders for the job title in multiple locales and add a workspace file to .gitignore.
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 13 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/backend/app/routers/resumes.py">

<violation number="1" location="apps/backend/app/routers/resumes.py:853">
P1: Job title override can be lost after refinement because it is only applied before `refine_resume()` and never re-applied before persisting the tailored resume.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@@ -362,10 +362,15 @@ def _protect_custom_sections(
def _preserve_personal_info(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Job title override can be lost after refinement because it is only applied before refine_resume() and never re-applied before persisting the tailored resume.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/backend/app/routers/resumes.py, line 853:

<comment>Job title override can be lost after refinement because it is only applied before `refine_resume()` and never re-applied before persisting the tailored resume.</comment>

<file context>
@@ -833,6 +850,7 @@ async def _improve_preview_flow(
     improved_data, preserve_warnings = _preserve_personal_info(
         original_resume_data,
         improved_data,
+        job_title_override=job.get("job_title"),
     )
     response_warnings.extend(preserve_warnings)
</file context>

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazyscriptright crazyscriptright changed the title Job title feature Job title to tailoring flow May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant