Skip to content

Change kallax.NumericID as PK from serial to bigserial#266

Open
kaasasolut wants to merge 1 commit into
src-d:masterfrom
kaasa-solution:master
Open

Change kallax.NumericID as PK from serial to bigserial#266
kaasasolut wants to merge 1 commit into
src-d:masterfrom
kaasa-solution:master

Conversation

@kaasasolut

Copy link
Copy Markdown

serial and bigint do not match. serial is 4 bytes long, while bigint is 8 bytes long.
See the documentation of the current version and of the oldest version I could find, 7.2 from 2002.

Because the type of NumericID is int64, I changed serial to bigserial.

Signed-off-by: Abdülhamit Yilmaz <mr.yilmaz@gmx.de>
@nadiamoe

nadiamoe commented May 2, 2018

Copy link
Copy Markdown
Contributor

Looks nice to me. I'd need to do a quick test to see how this affects migration schemas generated with serial tho, to ensure it is not breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants