Skip to content

Use gopkg.in/Masterminds/squirrel.v1 instead of github.com/Masterminds/squirrel#280

Open
faide wants to merge 1 commit into
src-d:masterfrom
faide:master
Open

Use gopkg.in/Masterminds/squirrel.v1 instead of github.com/Masterminds/squirrel#280
faide wants to merge 1 commit into
src-d:masterfrom
faide:master

Conversation

@faide

@faide faide commented Jun 28, 2018

Copy link
Copy Markdown

because the github version pulls from master and is not in synch with what kallax uses from squirrel.

See #279 for more reference

…s/squirrel

Signed-off-by: Florent AIDE <florent.aide@gmail.com>
@nadiamoe nadiamoe self-assigned this Jul 1, 2018
@nadiamoe

nadiamoe commented Jul 1, 2018

Copy link
Copy Markdown
Contributor

Which go version are you using? According to squirrel's README:

NOTE: as of Go 1.6, go get correctly clones the Github default branch (which is v1 in this repo).
import "github.com/Masterminds/squirrel"

PR seems harmless and more explicit tho, so I'm inclined to merge it. Just want to know which is the root cause of the problem.

@faide

faide commented Jul 1, 2018 via email

Copy link
Copy Markdown
Author

@WnP

WnP commented Feb 19, 2019

Copy link
Copy Markdown

I'm using go version go1.11.1 linux/amd64 and have the same issue, this PR fix it.
Thanks @faide

@nadiamoe nadiamoe removed their assignment Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants