Fix missing "Cookies are not cached" translation key#74
Open
Rushaway wants to merge 7 commits into
Open
Conversation
Updated French translations for map chooser phrases.
Updated Russian translations for map voting phrases in mapchooser_extended.
There was a problem hiding this comment.
Pull request overview
Fixes a runtime SourceMod exception in Nominations Extended by adding the missing translation phrase key used by the nomstatus command (%t lookup for "Cookies are not cached"), ensuring the phrase exists across supported locales.
Changes:
- Added
"Cookies are not cached"phrase to the base (English) translation file. - Added the same phrase key to
chi,es,fr, andrulocale translation files.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| addons/sourcemod/translations/mapchooser_extended.phrases.txt | Adds the missing English phrase key used by nomstatus. |
| addons/sourcemod/translations/chi/mapchooser_extended.phrases.txt | Adds the missing Chinese locale phrase key to prevent lookup exceptions. |
| addons/sourcemod/translations/es/mapchooser_extended.phrases.txt | Adds the missing Spanish locale phrase key to prevent lookup exceptions. |
| addons/sourcemod/translations/fr/mapchooser_extended.phrases.txt | Adds the missing French locale phrase key to prevent lookup exceptions. |
| addons/sourcemod/translations/ru/mapchooser_extended.phrases.txt | Adds the missing Russian locale phrase key to prevent lookup exceptions. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
This PR fixes a runtime SourceMod exception caused by a missing translation phrase key used by the nominations status command.
Problem
When running
nomstatus, the plugin calls the phrase key"Cookies are not cached"via%t. #72That key was missing in translation files, which triggered:
Exception reported: Language phrase "Cookies are not cached" not foundnominations_extended.smxChanges
Added the missing phrase key
"Cookies are not cached"Impact
nomstatusworks correctly for English, Chinese, Spanish, French, and Russian locales.Validation