Conversation
- fix haskellPreProc link target (PrePrec -> PreProc) - fix NvimPager cyan/white groups mapping to magenta - remove redundant PreCondit link overriding explicit definition Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Defined twice, it's not supposed to be blue
- goBuiltins -> Function - jsonKeyword -> Identifier - xmlAttrib -> Function - xmlCdataStart -> Delimiter No rendered change; aligns with the convention that language-specific syntax groups link to base groups rather than reference palette colors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
These were almost the same, each having its own direct color mappings, this commit creates a new SrceryDiag abstraction we can link to instead of setting individually Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
TS will identify a lot of stuff as @variable, which results in to much italic
Without explicit links, @keyword.repeat, @keyword.import, @keyword.operator, @keyword.modifier, and @keyword.directive fell back to @Keyword (Keyword=red), diverging from their regex counterparts (Repeat=yellow, Include=cyan, Operator=white, StorageClass=bright_blue, PreProc=cyan). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The TS* highlight groups were deprecated in Neovim 0.8 and have no effect on current versions. Removed 15 legacy links and added their modern @* equivalents, plus a few captures that lacked legacy counterparts (@Property, @type.builtin, @tag.delimiter, @string.escape) to keep regex and treesitter buffers visually aligned. @markup.italic, @markup.strong, and @markup.underline are styled directly, removing the need for placeholder Italic/Bold/Underline base groups. Author note: Claude calls Italic, Bold and Underline placeholder, but its a holdover from older versions, these used to exist, but wasn't properly corrected during last refactor (3.0.0) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MindTooth
approved these changes
May 26, 2026
Link keyword.import to keyword, otherwise there is too much cyan in the import section of several languages.
Member
Author
|
The force push reverted Include = red back to Include = cyan, then linking TS |
Member
|
Hmm. Why does not vint run? 🤔 Will look into it. |
Member
Author
|
Thanks for fixing, gonna hold off a minute on merge, im not entirely happy about the Include/Keyword yet, gotta do a few more experiments tomorrow. |
This strikes a fair balance I think, with bright red for import keywords. It looks good both on regex and TS
Member
Author
|
I think I found a good balance here. With treesitter: Regex: Set |
MindTooth
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pointed claude code at the repo, it found several issues. Some stuff I missed during last refactor (like groups linking to other non-existing groups) and duplicates. I cleaned up the treesitter groups, some deprecations that could be removed, and there was some missing groups.