Skip to content

Commit 9aad8a0

Browse files
committed
Include aggregate doc/install goals in scoping filter
Per @chatgpt-codex-connector review on #4: docs is also reached via \`make docs\` (which routes to srcs-doc + \$(DOCTARGETS)) and via \`make install INSTALLDOC=all\` (do-install-all has docs in its prereqs). In those cases MAKECMDGOALS only contains \`docs\` or \`install\`/ \`install-all\`/\`reinstall\`, so the previous filter stayed false and the ordering between prepare-gems and ext/configure-ext.mk regen was not enforced -- a clean-tree parallel docs install could still race. Add \`docs install install-all install-doc install-html install-rdoc reinstall\` to the filter. For \`make install INSTALLDOC=nodoc\`, prepare-gems was already pulled in transitively via pre-install-gem, so this only adds an ordering constraint, not a new fetch. Verified with \`make -n\` on a clean tree: plain \`make\` does not extract gems; \`make docs\`, \`make install\`, and \`make html\` do. https://claude.ai/code/session_01YRoRyZPew2LtN6u6BX8bzx
1 parent 5affd5f commit 9aad8a0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

defs/gmake.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ extract-gems: | $(call foreach-bundled-gems-rev,bundled-gem-extracted)
369369
# prepare-gems may not have run yet, so make the dep explicit for the
370370
# docs goals. Other targets are left alone so a plain `make` doesn't
371371
# reach for prepare-gems -> update-gems (network).
372-
ifneq ($(filter rdoc rdoc:% html html-server rdoc-coverage undocumented,$(MAKECMDGOALS)),)
372+
ifneq ($(filter rdoc rdoc:% html html-server rdoc-coverage undocumented docs install install-all install-doc install-html install-rdoc reinstall,$(MAKECMDGOALS)),)
373373
ext/configure-ext.mk: $(HAVE_BASERUBY:yes=prepare-gems)
374374
endif
375375

0 commit comments

Comments
 (0)