Skip to content

Commit 0f6cedb

Browse files
committed
clean up
1 parent 24c065a commit 0f6cedb

202 files changed

Lines changed: 1831 additions & 2718 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/TurboHTTP.API.Tests/ModuleInit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public static void Init()
99
{
1010
VerifyDiffPlex.Initialize();
1111
VerifierSettings.ScrubLinesContaining("[assembly: ReleaseDateAttribute(");
12-
Verifier.UseProjectRelativeDirectory("verify");
12+
UseProjectRelativeDirectory("verify");
1313
VerifierSettings.UniqueForRuntime();
1414
VerifierSettings.InitializePlugins();
1515
}

src/TurboHTTP.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt

Lines changed: 2 additions & 86 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ namespace TurboHTTP
6060
public bool AllowServerPush { get; set; }
6161
public bool EnableAltSvcDiscovery { get; set; }
6262
public System.TimeSpan IdleTimeout { get; set; }
63-
public long MaxBatchWeight { get; set; }
6463
public int MaxConnectionsPerServer { get; set; }
6564
public int MaxFieldSectionSize { get; set; }
6665
public int MaxReconnectAttempts { get; set; }
@@ -222,6 +221,8 @@ namespace TurboHTTP.Diagnostics
222221
}
223222
public static class TurboTraceExtensions
224223
{
224+
public static OpenTelemetry.Metrics.MeterProviderBuilder AddTurboHttpMetrics(this OpenTelemetry.Metrics.MeterProviderBuilder builder) { }
225+
public static OpenTelemetry.Trace.TracerProviderBuilder AddTurboHttpTracing(this OpenTelemetry.Trace.TracerProviderBuilder builder) { }
225226
public static Microsoft.Extensions.DependencyInjection.IServiceCollection AddTurboLoggerTracing(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, TurboHTTP.Diagnostics.TurboTraceCategory categories = 1023, TurboHTTP.Diagnostics.TurboTraceLevel minimumLevel = 1) { }
226227
public static Microsoft.Extensions.DependencyInjection.IServiceCollection AddTurboTracing(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, TurboHTTP.Diagnostics.ITurboTraceListener listener, TurboHTTP.Diagnostics.TurboTraceCategory categories = 1023, TurboHTTP.Diagnostics.TurboTraceLevel minimumLevel = 1) { }
227228
}
@@ -285,89 +286,4 @@ namespace TurboHTTP.Protocol.Cookies
285286
void AddCookiesToRequest(System.Uri requestUri, ref System.Net.Http.HttpRequestMessage request);
286287
void ProcessResponse(System.Uri requestUri, System.Net.Http.HttpResponseMessage response);
287288
}
288-
}
289-
namespace TurboHTTP.Protocol.Http2.Hpack
290-
{
291-
public static class HpackStaticTable
292-
{
293-
public const int StaticCount = 61;
294-
[System.Runtime.CompilerServices.TupleElementNames(new string[] {
295-
"Name",
296-
"Value"})]
297-
public static readonly System.ValueTuple<string, string>[] Entries;
298-
}
299-
}
300-
namespace TurboHTTP.Protocol.Http3
301-
{
302-
public sealed class Http3ConnectionReuseDecision : System.IEquatable<TurboHTTP.Protocol.Http3.Http3ConnectionReuseDecision>
303-
{
304-
public Http3ConnectionReuseDecision() { }
305-
public bool CanReuse { get; }
306-
public string Reason { get; }
307-
public static TurboHTTP.Protocol.Http3.Http3ConnectionReuseDecision NewConnection(string reason) { }
308-
public static TurboHTTP.Protocol.Http3.Http3ConnectionReuseDecision Reuse(string reason) { }
309-
}
310-
public enum Http3DecodeStatus
311-
{
312-
Success = 0,
313-
NeedMoreData = 1,
314-
}
315-
}
316-
namespace TurboHTTP.Protocol.Http3.Qpack
317-
{
318-
public sealed class DecoderInstruction
319-
{
320-
public DecoderInstruction() { }
321-
public int IntValue { get; init; }
322-
public TurboHTTP.Protocol.Http3.Qpack.DecoderInstructionType Type { get; init; }
323-
}
324-
public enum DecoderInstructionType
325-
{
326-
SectionAcknowledgment = 0,
327-
StreamCancellation = 1,
328-
InsertCountIncrement = 2,
329-
}
330-
public sealed class EncoderInstruction
331-
{
332-
public EncoderInstruction() { }
333-
public int IntValue { get; init; }
334-
public bool IsStatic { get; init; }
335-
public byte[] Name { get; init; }
336-
public int NameIndex { get; init; }
337-
public string NameString { get; }
338-
public TurboHTTP.Protocol.Http3.Qpack.EncoderInstructionType Type { get; init; }
339-
public byte[] Value { get; init; }
340-
public string ValueString { get; }
341-
}
342-
public enum EncoderInstructionType
343-
{
344-
SetDynamicTableCapacity = 0,
345-
InsertWithNameReference = 1,
346-
InsertWithLiteralName = 2,
347-
Duplicate = 3,
348-
}
349-
public sealed class QpackDecodeResult
350-
{
351-
[System.Runtime.CompilerServices.TupleElementNames(new string[] {
352-
"Name",
353-
"Value"})]
354-
public System.Collections.Generic.IReadOnlyList<System.ValueTuple<string, string>>? Headers { get; }
355-
public bool IsBlocked { get; }
356-
public int RequiredInsertCount { get; }
357-
public static TurboHTTP.Protocol.Http3.Qpack.QpackDecodeResult Blocked(int requiredInsertCount) { }
358-
public static TurboHTTP.Protocol.Http3.Qpack.QpackDecodeResult Success([System.Runtime.CompilerServices.TupleElementNames(new string[] {
359-
"Name",
360-
"Value"})] System.Collections.Generic.IReadOnlyList<System.ValueTuple<string, string>> headers) { }
361-
}
362-
public enum QpackDecodeStatus
363-
{
364-
Success = 0,
365-
NeedMoreData = 1,
366-
}
367-
public readonly struct QpackEntry : System.IEquatable<TurboHTTP.Protocol.Http3.Qpack.QpackEntry>
368-
{
369-
public QpackEntry(string Name, string Value) { }
370-
public string Name { get; init; }
371-
public string Value { get; init; }
372-
}
373289
}

src/TurboHTTP.AcceptanceTests/Diagnostics/LoggingBridgeSpec.cs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,6 @@ public async ValueTask DisposeAsync()
6565
}
6666
}
6767

68-
/// <summary>
69-
/// Builds a fully DI-wired client, mirroring a user's Program.cs / Startup setup.
70-
/// Registers <see cref="ILoggerFactory"/> and <see cref="ActorSystem"/> as singletons
71-
/// so that <see cref="ITurboHttpClientFactory"/> picks them up via normal DI resolution.
72-
/// </summary>
7368
private ITurboHttpClient BuildClientViaUserDI(int serverPort, bool withTurboTrace = false)
7469
{
7570
_capture = new CapturingLoggerProvider();
@@ -128,11 +123,6 @@ private ITurboHttpClient BuildClientViaUserDI(int serverPort, bool withTurboTrac
128123
return _client;
129124
}
130125

131-
/// <summary>
132-
/// Starts a minimal in-process HTTP/1.1 server on a random loopback port.
133-
/// Accepts connections and responds with HTTP/1.1 200 OK for each request.
134-
/// No external server or Kestrel dependency required.
135-
/// </summary>
136126
private int StartFakeTcpServer()
137127
{
138128
var listener = new TcpListener(IPAddress.Loopback, 0);
@@ -261,9 +251,6 @@ public async Task TurboTrace_connection_events_should_route_to_MEL_via_AddTurboL
261251
e.Message.Contains("Connection opened:", StringComparison.OrdinalIgnoreCase));
262252
}
263253

264-
/// <summary>
265-
/// A simple <see cref="ILoggerProvider"/> that captures all log entries for assertion.
266-
/// </summary>
267254
private sealed class CapturingLoggerProvider : ILoggerProvider
268255
{
269256
public ConcurrentBag<LogEntry> Entries { get; } = [];

src/TurboHTTP.AcceptanceTests/H10/RequestCompressionSpec.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Akka.Streams.Dsl;
66
using TurboHTTP.Internal;
77
using TurboHTTP.Protocol.Semantics;
8-
using TurboHTTP.Streams;
98
using TurboHTTP.Streams.Stages.Features;
109
using TurboHTTP.Tests.Shared;
1110

src/TurboHTTP.AcceptanceTests/H10/ResilienceSpec.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
using Akka;
44
using Akka.Streams.Dsl;
55
using TurboHTTP.Internal;
6-
using TurboHTTP.Streams;
76
using TurboHTTP.Streams.Stages.Features;
87
using TurboHTTP.Tests.Shared;
98

src/TurboHTTP.AcceptanceTests/H10/SmokeSpec.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
using Akka;
44
using Akka.Streams.Dsl;
55
using TurboHTTP.Internal;
6-
using TurboHTTP.Streams;
76
using TurboHTTP.Tests.Shared;
87

98
namespace TurboHTTP.AcceptanceTests.H10;

src/TurboHTTP.AcceptanceTests/H2/ConnectionSpec.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ public async Task Post_with_body_followed_by_get_should_work_on_same_connection(
205205
var postBody = await postResponse.Content.ReadAsByteArrayAsync(TestContext.Current.CancellationToken);
206206
Assert.Equal(postPayload, postBody);
207207

208-
var getPath = "/h2/echo-path?q=1";
208+
const string getPath = "/h2/echo-path?q=1";
209209
var getRequest = new HttpRequestMessage(HttpMethod.Get, $"http://localhost{getPath}")
210210
{
211211
Version = HttpVersion.Version20
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
using System.Runtime.CompilerServices;
2+
using TurboHTTP.Internal;
3+
4+
namespace TurboHTTP.AcceptanceTests;
5+
6+
public static class ModuleInit
7+
{
8+
[ModuleInitializer]
9+
public static void Init()
10+
{
11+
NetworkBuffer.ConfigurePoolSize(0);
12+
}
13+
}

src/TurboHTTP.AcceptanceTests/Proxy/ProxyConnectSpec.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ private static ConnectItem ToConnectItem(StreamAcquireItem acquire)
4141

4242
var connectResponseConsumed = false;
4343
var tunnelFlow = Flow.Create<IOutputItem>()
44-
.Select(item => item is StreamAcquireItem acquire ? (IOutputItem)ToConnectItem(acquire) : item)
44+
.Select(item => item is StreamAcquireItem acquire ? ToConnectItem(acquire) : item)
4545
.Via(Flow.FromGraph<IOutputItem, IInputItem, NotUsed>(fake))
4646
.Where(item =>
4747
{

src/TurboHTTP.StreamTests/Caching/CacheBidiAsyncBodySpec.cs

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,6 @@
88

99
namespace TurboHTTP.StreamTests.Caching;
1010

11-
/// <summary>
12-
/// RFC 9111 §3 — CacheBidiStage async body read path tests.
13-
/// Verifies that GetAsyncCallback keeps the stage scope alive during slow body reads,
14-
/// preventing GroupByHostKeyStage from completing the substream prematurely.
15-
/// </summary>
16-
/// <remarks>
17-
/// Stage under test: <see cref="CacheBidiStage"/>.
18-
/// RFC 9111 §3: Storing responses in a cache — async body read for cache storage.
19-
/// </remarks>
2011
public sealed class CacheBidiAsyncBodySpec : StreamTestBase
2112
{
2213
/// <summary>
@@ -77,7 +68,6 @@ private Task<IImmutableList<HttpResponseMessage>> RunResponseAsync(
7768
return RunnableGraph.FromGraph(graph).Run(Materializer);
7869
}
7970

80-
8171
[Trait("RFC", "RFC9111-3")]
8272
[Fact(Timeout = 10_000)]
8373
public async Task CacheBidiStage_should_push_response_immediately_while_body_read_is_pending()
@@ -150,4 +140,4 @@ public async Task CacheBidiStage_should_store_in_cache_after_async_body_complete
150140
Assert.NotNull(entry);
151141
Assert.Equal("pending body", System.Text.Encoding.UTF8.GetString(entry.Body.Span));
152142
}
153-
}
143+
}

0 commit comments

Comments
 (0)