Skip to content

Commit 33a852c

Browse files
st0o0st0o0
committed
TASK-035-007: Fix remaining TurboHttp→TurboHTTP string literals and verify full build
Fixed string literal references (diagnostics source names, metrics meter name, request option keys, comments) that were missed during the namespace rename. All 3267 unit tests and 765 stream tests pass. Build compiles with zero errors.
1 parent fecfab3 commit 33a852c

19 files changed

Lines changed: 72 additions & 72 deletions

.maggus/features/feature_035.md renamed to .maggus/features/feature_035_completed.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -259,12 +259,12 @@ Also verify:
259259
- CI workflow YAML is syntactically valid
260260

261261
**Acceptance Criteria:**
262-
- [ ] `dotnet restore` succeeds
263-
- [ ] `dotnet build --configuration Release` succeeds with zero errors
264-
- [ ] All unit tests pass (`TurboHTTP.Tests`)
265-
- [ ] All stream tests pass (`TurboHTTP.StreamTests`)
266-
- [ ] No remaining `TurboHttp` references outside of type names (class/method names)
267-
- [ ] `git status` shows only expected changes
262+
- [x] `dotnet restore` succeeds
263+
- [x] `dotnet build --configuration Release` succeeds with zero errors
264+
- [x] All unit tests pass (`TurboHTTP.Tests`)
265+
- [x] All stream tests pass (`TurboHTTP.StreamTests`)
266+
- [x] No remaining `TurboHttp` references outside of type names (class/method names)
267+
- [x] `git status` shows only expected changes
268268

269269
## Task Dependency Graph
270270

‎src/TurboHTTP.StreamTests/Http3/Http30ConnectionReuseSpec.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ namespace TurboHTTP.StreamTests.Http3;
1010
/// <summary>
1111
/// Tests HTTP/3 version-dispatch in the connection reuse stage per RFC 9114 §3.3.
1212
/// Verifies that <see cref="ConnectionReuseStage"/> routes HTTP/3+ responses through
13-
/// <see cref="TurboHttp.Protocol.Http3.Http3ConnectionReuseEvaluator"/> instead of
14-
/// <see cref="TurboHttp.Protocol.Http11.ConnectionReuseEvaluator"/>.
13+
/// <see cref="TurboHTTP.Protocol.Http3.Http3ConnectionReuseEvaluator"/> instead of
14+
/// <see cref="TurboHTTP.Protocol.Http11.ConnectionReuseEvaluator"/>.
1515
/// </summary>
1616
/// <remarks>
1717
/// Stage under test: <see cref="ConnectionReuseStage"/>.

‎src/TurboHTTP.StreamTests/Semantics/RetryCoreSpec.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ namespace TurboHTTP.StreamTests.Semantics;
1818
/// </remarks>
1919
public sealed class RetryCoreSpec : StreamTestBase
2020
{
21-
private static readonly HttpRequestOptionsKey<int> AttemptCountKey = new("TurboHttp.RetryAttemptCount");
21+
private static readonly HttpRequestOptionsKey<int> AttemptCountKey = new("TurboHTTP.RetryAttemptCount");
2222

2323
/// <summary>
2424
/// Runs requests through the request direction (In1→Out1) of the BidiStage.

‎src/TurboHTTP.Tests/Diagnostics/LoggerTraceListenerSpec.cs‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public void Write_should_call_logger_with_correct_level()
3333

3434
listener.Write(in evt);
3535

36-
var logger = _factory.CreatedLoggers["TurboHttp.Trace.Protocol"];
36+
var logger = _factory.CreatedLoggers["TurboHTTP.Trace.Protocol"];
3737
Assert.Single(logger.LogEntries);
3838
Assert.Equal(LogLevel.Warning, logger.LogEntries[0].Level);
3939
}
@@ -48,7 +48,7 @@ public void InfoLevel_should_map_to_information()
4848

4949
listener.Write(in evt);
5050

51-
var logger = _factory.CreatedLoggers["TurboHttp.Trace.Protocol"];
51+
var logger = _factory.CreatedLoggers["TurboHTTP.Trace.Protocol"];
5252
Assert.Single(logger.LogEntries);
5353
Assert.Equal(LogLevel.Information, logger.LogEntries[0].Level);
5454
}
@@ -63,7 +63,7 @@ public void DebugLevel_should_map_to_debug()
6363

6464
listener.Write(in evt);
6565

66-
var logger = _factory.CreatedLoggers["TurboHttp.Trace.Protocol"];
66+
var logger = _factory.CreatedLoggers["TurboHTTP.Trace.Protocol"];
6767
Assert.Equal(LogLevel.Debug, logger.LogEntries[0].Level);
6868
}
6969

@@ -77,7 +77,7 @@ public void WarningLevel_should_map_to_warning()
7777

7878
listener.Write(in evt);
7979

80-
var logger = _factory.CreatedLoggers["TurboHttp.Trace.Protocol"];
80+
var logger = _factory.CreatedLoggers["TurboHTTP.Trace.Protocol"];
8181
Assert.Equal(LogLevel.Warning, logger.LogEntries[0].Level);
8282
}
8383

@@ -91,7 +91,7 @@ public void ErrorLevel_should_map_to_error()
9191

9292
listener.Write(in evt);
9393

94-
var logger = _factory.CreatedLoggers["TurboHttp.Trace.Protocol"];
94+
var logger = _factory.CreatedLoggers["TurboHTTP.Trace.Protocol"];
9595
Assert.Equal(LogLevel.Error, logger.LogEntries[0].Level);
9696
}
9797

@@ -105,7 +105,7 @@ public void TraceLevel_should_map_to_trace()
105105

106106
listener.Write(in evt);
107107

108-
var logger = _factory.CreatedLoggers["TurboHttp.Trace.Protocol"];
108+
var logger = _factory.CreatedLoggers["TurboHTTP.Trace.Protocol"];
109109
Assert.Equal(LogLevel.Trace, logger.LogEntries[0].Level);
110110
}
111111

@@ -139,7 +139,7 @@ public void Write_should_include_source_type_and_hash()
139139

140140
listener.Write(in evt);
141141

142-
var logger = _factory.CreatedLoggers["TurboHttp.Trace.Protocol"];
142+
var logger = _factory.CreatedLoggers["TurboHTTP.Trace.Protocol"];
143143
var entry = Assert.Single(logger.LogEntries);
144144
Assert.Contains("MyDecoder", entry.Message);
145145
Assert.Contains("1A2B3C4D", entry.Message);
@@ -156,7 +156,7 @@ public void Write_should_skip_format_when_logger_disabled()
156156

157157
listener.Write(in evt);
158158

159-
var logger = factory.CreatedLoggers["TurboHttp.Trace.Protocol"];
159+
var logger = factory.CreatedLoggers["TurboHTTP.Trace.Protocol"];
160160
Assert.Empty(logger.LogEntries);
161161
}
162162

@@ -173,16 +173,16 @@ public void LoggerNames_should_follow_pattern()
173173

174174
var expectedNames = new[]
175175
{
176-
"TurboHttp.Trace.Connection",
177-
"TurboHttp.Trace.Protocol",
178-
"TurboHttp.Trace.Request",
179-
"TurboHttp.Trace.Response",
180-
"TurboHttp.Trace.Cache",
181-
"TurboHttp.Trace.Redirect",
182-
"TurboHttp.Trace.Retry",
183-
"TurboHttp.Trace.Pool",
184-
"TurboHttp.Trace.Transport",
185-
"TurboHttp.Trace.Stream",
176+
"TurboHTTP.Trace.Connection",
177+
"TurboHTTP.Trace.Protocol",
178+
"TurboHTTP.Trace.Request",
179+
"TurboHTTP.Trace.Response",
180+
"TurboHTTP.Trace.Cache",
181+
"TurboHTTP.Trace.Redirect",
182+
"TurboHTTP.Trace.Retry",
183+
"TurboHTTP.Trace.Pool",
184+
"TurboHTTP.Trace.Transport",
185+
"TurboHTTP.Trace.Stream",
186186
};
187187

188188
foreach (var name in expectedNames)

‎src/TurboHTTP.Tests/Diagnostics/TurboHttpInstrumentationSpec.cs‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public void StartRequest_should_create_request_activity()
4141
var activity = TurboHttpInstrumentation.StartRequest(request);
4242

4343
Assert.NotNull(activity);
44-
Assert.Equal("TurboHttp.Request", activity.OperationName);
44+
Assert.Equal("TurboHTTP.Request", activity.OperationName);
4545
Assert.Equal(ActivityKind.Client, activity.Kind);
4646
}
4747

@@ -100,7 +100,7 @@ public void StartRedirect_should_create_redirect_activity()
100100
var activity = TurboHttpInstrumentation.StartRedirect(uri, 301);
101101

102102
Assert.NotNull(activity);
103-
Assert.Equal("TurboHttp.Redirect", activity.OperationName);
103+
Assert.Equal("TurboHTTP.Redirect", activity.OperationName);
104104
Assert.Equal(ActivityKind.Client, activity.Kind);
105105
}
106106

@@ -145,7 +145,7 @@ public void MultipleRedirectHops_should_produce_separate_activities()
145145
hop3?.Stop();
146146

147147
var redirectActivities = _activities
148-
.Where(a => a.OperationName == "TurboHttp.Redirect")
148+
.Where(a => a.OperationName == "TurboHTTP.Redirect")
149149
.ToList();
150150

151151
Assert.Equal(3, redirectActivities.Count);
@@ -185,7 +185,7 @@ public void StartRetry_should_create_retry_activity()
185185
var activity = TurboHttpInstrumentation.StartRetry(1);
186186

187187
Assert.NotNull(activity);
188-
Assert.Equal("TurboHttp.Retry", activity.OperationName);
188+
Assert.Equal("TurboHTTP.Retry", activity.OperationName);
189189
Assert.Equal(ActivityKind.Client, activity.Kind);
190190
}
191191

@@ -221,7 +221,7 @@ public void MultipleRetryAttempts_should_produce_separate_activities()
221221
retry2?.Stop();
222222

223223
var retryActivities = _activities
224-
.Where(a => a.OperationName == "TurboHttp.Retry")
224+
.Where(a => a.OperationName == "TurboHTTP.Retry")
225225
.ToList();
226226

227227
Assert.Equal(2, retryActivities.Count);
@@ -258,7 +258,7 @@ public void StartCacheLookup_should_create_cache_lookup_activity()
258258
var activity = TurboHttpInstrumentation.StartCacheLookup(uri);
259259

260260
Assert.NotNull(activity);
261-
Assert.Equal("TurboHttp.CacheLookup", activity.OperationName);
261+
Assert.Equal("TurboHTTP.CacheLookup", activity.OperationName);
262262
Assert.Equal(ActivityKind.Client, activity.Kind);
263263
}
264264

@@ -352,7 +352,7 @@ public void SetError_on_root_activity_should_set_all_attributes()
352352

353353
TurboHttpInstrumentation.SetError(activity, exception);
354354

355-
Assert.Equal("TurboHttp.Request", activity.OperationName);
355+
Assert.Equal("TurboHTTP.Request", activity.OperationName);
356356
Assert.Equal("ERROR", activity.GetTagItem("otel.status_code"));
357357
Assert.Equal(typeof(HttpRequestException).FullName, activity.GetTagItem("exception.type"));
358358
Assert.Equal("Connection reset by peer", activity.GetTagItem("exception.message"));
@@ -371,7 +371,7 @@ public void StartRequest_should_return_null_when_no_listener()
371371

372372
// Activity may or may not be null depending on other test listeners,
373373
// but verify our source name is correct
374-
Assert.Equal("TurboHttp", TurboHttpInstrumentation.SourceName);
374+
Assert.Equal("TurboHTTP", TurboHttpInstrumentation.SourceName);
375375
}
376376

377377

@@ -435,10 +435,10 @@ public void FullLifecycle_with_redirect_and_retry()
435435

436436
// Verify span counts
437437
Assert.Equal(5, _activities.Count); // root + 2 redirects + 1 retry + 1 cache
438-
Assert.Single(_activities, a => a.OperationName == "TurboHttp.Request");
439-
Assert.Equal(2, _activities.Count(a => a.OperationName == "TurboHttp.Redirect"));
440-
Assert.Single(_activities, a => a.OperationName == "TurboHttp.Retry");
441-
Assert.Single(_activities, a => a.OperationName == "TurboHttp.CacheLookup");
438+
Assert.Single(_activities, a => a.OperationName == "TurboHTTP.Request");
439+
Assert.Equal(2, _activities.Count(a => a.OperationName == "TurboHTTP.Redirect"));
440+
Assert.Single(_activities, a => a.OperationName == "TurboHTTP.Retry");
441+
Assert.Single(_activities, a => a.OperationName == "TurboHTTP.CacheLookup");
442442

443443
// Verify root span has response status
444444
Assert.Equal(200, rootActivity.GetTagItem("http.response.status_code"));
@@ -459,7 +459,7 @@ public void FullLifecycle_with_error()
459459
rootActivity.Stop();
460460

461461
Assert.Single(_activities);
462-
Assert.Equal("TurboHttp.Request", rootActivity.OperationName);
462+
Assert.Equal("TurboHTTP.Request", rootActivity.OperationName);
463463
Assert.Equal(ActivityStatusCode.Error, rootActivity.Status);
464464
Assert.Equal("ERROR", rootActivity.GetTagItem("otel.status_code"));
465465
Assert.Equal("Connection refused", rootActivity.GetTagItem("exception.message"));
@@ -470,7 +470,7 @@ public void FullLifecycle_with_error()
470470
[Fact]
471471
public void ActivitySource_should_have_correct_name()
472472
{
473-
Assert.Equal("TurboHttp", TurboHttpInstrumentation.Source.Name);
473+
Assert.Equal("TurboHTTP", TurboHttpInstrumentation.Source.Name);
474474
}
475475

476476
[Fact]

‎src/TurboHTTP.Tests/Diagnostics/TurboHttpMetricsSpec.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public void Dispose()
4545
[Fact]
4646
public void Meter_should_have_correct_name()
4747
{
48-
Assert.Equal("TurboHttp", TurboHttpMetrics.Meter.Name);
48+
Assert.Equal("TurboHTTP", TurboHttpMetrics.Meter.Name);
4949
}
5050

5151
[Fact]

‎src/TurboHTTP/Diagnostics/LoggerTraceListener.cs‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,16 @@ private static Dictionary<TurboTraceCategory, ILogger> CreateLoggers(ILoggerFact
5353
{
5454
return new Dictionary<TurboTraceCategory, ILogger>
5555
{
56-
[TurboTraceCategory.Connection] = loggerFactory.CreateLogger("TurboHttp.Trace.Connection"),
57-
[TurboTraceCategory.Protocol] = loggerFactory.CreateLogger("TurboHttp.Trace.Protocol"),
58-
[TurboTraceCategory.Request] = loggerFactory.CreateLogger("TurboHttp.Trace.Request"),
59-
[TurboTraceCategory.Response] = loggerFactory.CreateLogger("TurboHttp.Trace.Response"),
60-
[TurboTraceCategory.Cache] = loggerFactory.CreateLogger("TurboHttp.Trace.Cache"),
61-
[TurboTraceCategory.Redirect] = loggerFactory.CreateLogger("TurboHttp.Trace.Redirect"),
62-
[TurboTraceCategory.Retry] = loggerFactory.CreateLogger("TurboHttp.Trace.Retry"),
63-
[TurboTraceCategory.Pool] = loggerFactory.CreateLogger("TurboHttp.Trace.Pool"),
64-
[TurboTraceCategory.Transport] = loggerFactory.CreateLogger("TurboHttp.Trace.Transport"),
65-
[TurboTraceCategory.Stream] = loggerFactory.CreateLogger("TurboHttp.Trace.Stream"),
56+
[TurboTraceCategory.Connection] = loggerFactory.CreateLogger("TurboHTTP.Trace.Connection"),
57+
[TurboTraceCategory.Protocol] = loggerFactory.CreateLogger("TurboHTTP.Trace.Protocol"),
58+
[TurboTraceCategory.Request] = loggerFactory.CreateLogger("TurboHTTP.Trace.Request"),
59+
[TurboTraceCategory.Response] = loggerFactory.CreateLogger("TurboHTTP.Trace.Response"),
60+
[TurboTraceCategory.Cache] = loggerFactory.CreateLogger("TurboHTTP.Trace.Cache"),
61+
[TurboTraceCategory.Redirect] = loggerFactory.CreateLogger("TurboHTTP.Trace.Redirect"),
62+
[TurboTraceCategory.Retry] = loggerFactory.CreateLogger("TurboHTTP.Trace.Retry"),
63+
[TurboTraceCategory.Pool] = loggerFactory.CreateLogger("TurboHTTP.Trace.Pool"),
64+
[TurboTraceCategory.Transport] = loggerFactory.CreateLogger("TurboHTTP.Trace.Transport"),
65+
[TurboTraceCategory.Stream] = loggerFactory.CreateLogger("TurboHTTP.Trace.Stream"),
6666
};
6767
}
6868
}

‎src/TurboHTTP/Diagnostics/TurboHttpMetrics.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@ namespace TurboHTTP.Diagnostics;
77
/// Central metrics class for TurboHttp instrumentation.
88
/// Uses <see cref="Meter"/> to emit OpenTelemetry-compatible metrics
99
/// following the HTTP semantic conventions.
10-
/// Consumers subscribe via <c>AddMeter("TurboHttp")</c> in the OTel SDK.
10+
/// Consumers subscribe via <c>AddMeter("TurboHTTP")</c> in the OTel SDK.
1111
/// </summary>
1212
public static class TurboHttpMetrics
1313
{
1414
/// <summary>
1515
/// The Meter name. Use this value with <c>AddMeter</c> to subscribe.
1616
/// </summary>
17-
public const string MeterName = "TurboHttp";
17+
public const string MeterName = "TurboHTTP";
1818

1919
private static readonly string Version =
2020
typeof(TurboHttpMetrics).Assembly

‎src/TurboHTTP/Internal/Messages.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public interface IControlItem : IOutputItem;
2222

2323
/// <summary>
2424
/// Signals the connection-reuse decision for the current request/response cycle.
25-
/// Emitted by <see cref="TurboHttp.Streams.Stages.Features.ConnectionReuseStage"/> based on RFC 9112 §9.
25+
/// Emitted by <see cref="TurboHTTP.Streams.Stages.Features.ConnectionReuseStage"/> based on RFC 9112 §9.
2626
/// Pooled to avoid per-request heap allocation on the hot path.
2727
/// </summary>
2828
public sealed class ConnectionReuseItem : IControlItem
@@ -219,7 +219,7 @@ public void Return()
219219
/// <summary>
220220
/// Carries an orphaned in-flight request whose pipelined response was never received
221221
/// because the server closed the connection. Emitted by
222-
/// <see cref="TurboHttp.Streams.Stages.Routing.Http11CorrelationStage"/> via the
222+
/// <see cref="TurboHTTP.Streams.Stages.Routing.Http11CorrelationStage"/> via the
223223
/// <c>OutControl</c> outlet so that upstream layers can re-issue the request on a
224224
/// fresh connection.
225225
/// </summary>
@@ -252,7 +252,7 @@ public enum TlsCloseKind
252252
/// <summary>
253253
/// Signals that the transport connection has closed, carrying the <see cref="TlsCloseKind"/>
254254
/// so that decoder stages can decide whether a partially buffered response is complete.
255-
/// Emitted by <see cref="TurboHttp.Transport.TcpConnectionStage"/> when the inbound data channel completes.
255+
/// Emitted by <see cref="TurboHTTP.Transport.TcpConnectionStage"/> when the inbound data channel completes.
256256
/// </summary>
257257
public record CloseSignalItem(TlsCloseKind CloseKind) : IInputItem
258258
{

‎src/TurboHTTP/Protocol/Http11/Http11Decoder.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ public bool TryDecodeEof(out HttpResponseMessage? response)
427427

428428
/// <summary>
429429
/// Returns any buffered remainder bytes and clears the remainder.
430-
/// Used by <see cref="TurboHttp.Streams.Stages.Decoding.Http11DecoderStage"/> to extract
430+
/// Used by <see cref="TurboHTTP.Streams.Stages.Decoding.Http11DecoderStage"/> to extract
431431
/// body data that was in the same chunk as headers for connection-close-delimited responses.
432432
/// </summary>
433433
public byte[] FlushRemainder()

0 commit comments

Comments
 (0)