Remove ignore-next-line (#335)

* Remove ignore-next-line

* Added getColumnMeta() stub

* Update PdoStatement.stub

* Update PdoQueryReflector.php

* Update PdoQueryReflector.php

* Update PdoQueryReflector.php

* Update PdoQueryReflector.php

* Update src/QueryReflection/PdoQueryReflector.php

* Update PdoQueryReflector.php

Author: staabm

config/PdoStatement.stub

@@ -17,4 +17,9 @@ class PDOStatement implements Traversable, IteratorAggregate
      * @return false|T
      */
     public function fetchObject($class = \stdclass::class, array $ctorArgs = array()) {}
+    
+    /**
+     * @return array{name: string, table: string, native_type: string, len: int, flags: array<int, string>, precision: int<0, max>, pdo_type: PDO::PARAM_* }|false
+     */
+    public function getColumnMeta(int $column) {}
 }

src/QueryReflection/PdoQueryReflector.php

@@ -18,7 +18,7 @@
 use function strtoupper;
 
 /**
- * @phpstan-type ColumnMeta array{name: string, table: string, native_type: string, len: int, flags: list<string>}
+ * @phpstan-type ColumnMeta array{name: string, table: string, native_type: string, len: int, flags: array<int, string>, precision: int<0, max>, pdo_type: PDO::PARAM_* }
  */
 final class PdoQueryReflector implements QueryReflector
 {
@@ -47,7 +47,7 @@ final class PdoQueryReflector implements QueryReflector
     private const MAX_CACHE_SIZE = 50;
 
     /**
-     * @var array<string, PDOException|list<ColumnMeta>|null>
+     * @var array<string, PDOException|array<int<0, max>, ColumnMeta>|null>
      */
     private array $cache = [];
 
@@ -165,22 +165,13 @@ private function simulateQuery(string $queryString)
         $columnIndex = 0;
         while ($columnIndex < $columnCount) {
             // see https://github.com/php/php-src/blob/master/ext/pdo_mysql/mysql_statement.c
+            /** @var ColumnMeta|false */
             $columnMeta = $stmt->getColumnMeta($columnIndex);
 
             if (false === $columnMeta) {
                 throw new ShouldNotHappenException('Failed to get column meta for column index '.$columnIndex);
             }
 
-            if (
-                !\array_key_exists('name', $columnMeta)
-                || !\array_key_exists('table', $columnMeta)
-                || !\array_key_exists('native_type', $columnMeta)
-                || !\array_key_exists('flags', $columnMeta)
-                || !\array_key_exists('len', $columnMeta)
-            ) {
-                throw new ShouldNotHappenException();
-            }
-
             $flags = $this->emulateMysqlFlags($columnMeta['native_type'], $columnMeta['table'], $columnMeta['name']);
             foreach ($flags as $flag) {
                 $columnMeta['flags'][] = $flag;
@@ -191,7 +182,6 @@ private function simulateQuery(string $queryString)
             ++$columnIndex;
         }
 
-        // @phpstan-ignore-next-line
         return $this->cache[$queryString];
     }