*c: rename local variable 'true' to 'cond' throughout cgen.c/txt.c#129
Merged
Conversation
With _Bool support added to kencc, 'true' is now a keyword (C23 boolean
constant, value 1). Using 'true' as a local variable or parameter name
in cgen.c/txt.c/cgen64.c causes syntax errors when those files are
compiled by the new DWARF-enabled 6c.
Affected files: 1c 2c 5c 6c 7c 8c 9c kc qc vc cgen.c,
5c 7c txt.c, 8c cgen64.c.
https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a widespread refactoring across multiple compiler backends, including 1c, 2c, 5c, 6c, 7c, 8c, 9c, kc, qc, and vc. The variable name "true" is renamed to "cond" within various code generation functions such as bcgen, boolgen, gopcode, and testv to improve code clarity and avoid naming conflicts. There are no review comments to evaluate, and I have no further feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With _Bool support added to kencc, 'true' is now a keyword (C23 boolean constant, value 1). Using 'true' as a local variable or parameter name in cgen.c/txt.c/cgen64.c causes syntax errors when those files are compiled by the new DWARF-enabled 6c.
Affected files: 1c 2c 5c 6c 7c 8c 9c kc qc vc cgen.c,
5c 7c txt.c, 8c cgen64.c.
https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs