From b4877397d6f1684027a068ad39d4cb736e08f369 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Thu, 21 May 2026 16:59:06 +0000
Subject: [PATCH] =?UTF-8?q?8c/cgen64.c:=20rename=20local=20var=20cond?=
 =?UTF-8?q?=E2=86=92vcond=20to=20unshadow=20cond()=20function?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Local variable `cond` in cgen64() shadowed the file-local `cond(int op)`
function (line 217).  With TBOOL in place, `true` is now a keyword and
the earlier true→cond rename in cgen.c made the shadowing problem visible
at build time: line 2570 `cond(l->op)` was resolved to the int variable
rather than the function, triggering "incompatible type: INT for op FUNC".

https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs
---
 sys/src/cmd/8c/cgen64.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/sys/src/cmd/8c/cgen64.c b/sys/src/cmd/8c/cgen64.c
index 7b29d1fe2..0ffa308b5 100644
--- a/sys/src/cmd/8c/cgen64.c
+++ b/sys/src/cmd/8c/cgen64.c
@@ -1564,7 +1564,7 @@ cgen64(Node *n, Node *nn)
 {
 	Type *dt;
 	uchar *args, (*cp)[VLEN], (**optab)[VLEN];
-	int li, ri, lri, dr, si, m, op, sh, cmp, cond;
+	int li, ri, lri, dr, si, m, op, sh, cmp, vcond;
 	Node *c, *d, *l, *r, *t, *s, nod1, nod2, nod3, nod4, nod5;
 
 	if(debug['g']) {
@@ -2093,40 +2093,40 @@ cgen64(Node *n, Node *nn)
 			break;
 		}
 
-		cond = 1;
+		vcond = 1;
 		optab = cmptab;
 		switch(op) {
 		case OEQ:
 			optab = NEtab;
-			cond = 0;
+			vcond = 0;
 			break;
 		case ONE:
 			optab = NEtab;
 			break;
 		case OLE:
 			args = GTargs;
-			cond = 0;
+			vcond = 0;
 			break;
 		case OGT:
 			args = GTargs;
 			break;
 		case OLS:
 			args = HIargs;
-			cond = 0;
+			vcond = 0;
 			break;
 		case OHI:
 			args = HIargs;
 			break;
 		case OLT:
 			args = GEargs;
-			cond = 0;
+			vcond = 0;
 			break;
 		case OGE:
 			args = GEargs;
 			break;
 		case OLO:
 			args = HSargs;
-			cond = 0;
+			vcond = 0;
 			break;
 		case OHS:
 			args = HSargs;
@@ -2138,7 +2138,7 @@ cgen64(Node *n, Node *nn)
 
 		switch(lri) {
 		case IMM(0, 0):
-			biggen(l, r, Z, cond, optab[T0i], args);
+			biggen(l, r, Z, vcond, optab[T0i], args);
 			break;
 		case IMM(0, 1):
 		case IMM(1, 0):
@@ -2147,14 +2147,14 @@ cgen64(Node *n, Node *nn)
 				diag(l, "bad whatof\n");
 				break;
 			case WCONST:
-				biggen(l, r, Z, cond, optab[T0i], args);
+				biggen(l, r, Z, vcond, optab[T0i], args);
 				break;
 			case WHARD:
 				reglcgen(&nod2, r, Z);
 				r = &nod2;
 				/* fall thru */
 			case WADDR:
-				biggen(l, r, Z, cond, optab[T0i], args);
+				biggen(l, r, Z, vcond, optab[T0i], args);
 				if(ri == WHARD)
 					regfree(r);
 				break;
@@ -2169,7 +2169,7 @@ cgen64(Node *n, Node *nn)
 				reglcgen(&nod2, r, Z);
 				r = &nod2;
 			}
-			biggen(l, r, Z, cond, optab[Tii], args);
+			biggen(l, r, Z, vcond, optab[Tii], args);
 			if(li == WHARD)
 				regfree(l);
 			if(ri == WHARD)