Skip to content

9src/cc: fix objs list to use objext, not hardcoded "o" #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staalmannen merged 1 commit into from
May 21, 2026
Merged

9src/cc: fix objs list to use objext, not hardcoded "o" #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sys/src/ape/9src/cc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ main(int argc, char *argv[])
suf++;
if(strcmp(suf, "c") == 0) {
append(&srcs, s);
append(&objs, changeext(s, "o"));
append(&objs, changeext(s, objext));

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of objext here is inconsistent with the check on line 173, which uses ot->o to recognize existing object files. If objext and ot->o are intended to represent the same architecture-specific extension, it would be better to use a single variable consistently. If they can differ, this change might cause files with the objext extension passed on the command line to be ignored by the recognition logic in the else if block, while still allowing .o files which may no longer be appropriate for the target architecture.

} else if(strcmp(suf, "o") == 0 ||
strcmp(suf, ot->o) == 0 ||
strcmp(suf, "a") == 0 ||
Expand Down
Loading