6l: declare cpos() in l.h#140
Merged
Merged
Conversation
asmbelf() in asm.c uses cpos() to capture file offsets, but cpos() was only declared locally in dwarf.c. Add the declaration to l.h alongside cflush(). https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Comment on lines
+372
to
374
| vlong cpos(void); | ||
| void ckoff(Sym*, long); | ||
| Prog* copyp(Prog*); |
There was a problem hiding this comment.
The function declarations in this header are maintained in alphabetical order. To follow this convention, cpos should be placed after copyp and before cputime (since 'ck' < 'co' < 'cp').
void ckoff(Sym*, long);
Prog* copyp(Prog*);
vlong cpos(void);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asmbelf() in asm.c uses cpos() to capture file offsets, but cpos() was only declared locally in dwarf.c. Add the declaration to l.h alongside cflush().
https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs