Skip to content

ld/dwarf: increase includestack from 16 to 64 #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staalmannen merged 1 commit into from
May 22, 2026
Merged

ld/dwarf: increase includestack from 16 to 64 #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sys/src/cmd/ld/dwarf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ addhistfile(char *zentry)
static struct {
int file;
vlong line;
} includestack[16];
} includestack[64];

@gemini-code-assist gemini-code-assist Bot May 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Increasing the stack size to 64 addresses the immediate issue, but using a hardcoded magic number is risky if bounds checks elsewhere in the code (e.g., in addhistfile) are not updated to match. It is recommended to use a named constant or the nelem() macro to ensure the array size and its bounds checks remain in sync. Additionally, given the minimal memory impact, a larger limit like 128 might be safer for extremely deep include chains.

} includestack[128];

static int includetop;
static vlong absline;

Expand Down
Loading