424 bridge priceaggregator prices#426
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
+ Coverage 95.79% 95.91% +0.11%
==========================================
Files 162 172 +10
Lines 14533 14949 +416
Branches 1364 1401 +37
==========================================
+ Hits 13922 14338 +416
Misses 498 498
Partials 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| function _credit( | ||
| address to_, | ||
| uint amountLD_, | ||
| uint32 srcEid_ | ||
| ) internal virtual override returns (uint amountReceivedLD) { | ||
| _requireNotPaused(to_); | ||
|
|
||
| return super._credit(to_, amountLD_, srcEid_); | ||
| } |
Check warning
Code scanning / Slither
Dead-code Warning
…ter => TokenOFTAdapter, STBL => token/main-token. ABI is changed accordingly in some places. IPlatform is not changed
| function _credit( | ||
| address to_, | ||
| uint amountLD_, | ||
| uint32 srcEid_ | ||
| ) internal virtual override returns (uint amountReceivedLD) { | ||
| _requireNotPaused(to_); | ||
|
|
||
| return super._credit(to_, amountLD_, srcEid_); | ||
| } |
Check warning
Code scanning / Slither
Dead-code Warning
| 0x7331a1638fe957f8dc3395f52254374f52b3cbbdf185d4405a764a49dfb7f400; | ||
|
|
||
| /// @notice LayerZero v2 Endpoint address | ||
| address public immutable LZ_ENDPOINT; |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| function updateOtherChainsPowers(address[] memory users, uint[] memory powers) external { | ||
| DaoStorage storage $ = _getDaoStorage(); | ||
| require($.otherChainsPowersWhitelist[msg.sender], NotOtherChainsPowersWhitelisted()); | ||
|
|
||
| uint len = users.length; | ||
| require(len == powers.length, IControllable.IncorrectArrayLength()); | ||
|
|
||
| uint epoch = block.timestamp; | ||
| require(epoch > $.otherChainsEpoch, WrongValue()); // just for safety forbid double update in the same block | ||
| $.otherChainsEpoch = epoch; | ||
|
|
||
| OtherChainsPowers storage poc = $.otherChainsPowers[epoch]; | ||
|
|
||
| for (uint i; i < len; ++i) { | ||
| poc.powers.set(users[i], powers[i]); | ||
| } | ||
|
|
||
| emit PowersOtherChainsUpdated(block.timestamp); | ||
| } |
Check notice
Code scanning / Slither
Block timestamp Low
| /* Initializers */ | ||
| /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/ | ||
|
|
||
| constructor(address lzEndpoint_) { |
Check notice
Code scanning / Slither
Missing zero address validation Low
…ctly with flag --recursive (wrong versions of OZ and std-foundry are used)
| address internal immutable _token; | ||
| uint internal immutable _amountToSend; | ||
|
|
||
| constructor(address token_, uint amountToSend) { |
Check notice
Code scanning / Slither
Missing zero address validation Low test
…regatorOApp tests use BridgeTestLib
…nd BridgedPriceOracle on plasma. Remove addresses from BridgeTestLib. Simplify Setup.XXX scripts
| contract MockXToken { | ||
| using SafeERC20 for IERC20; | ||
|
|
||
| address internal _token; |
Check warning
Code scanning / Slither
State variables that could be declared immutable Warning test
| using SafeERC20 for IERC20; | ||
|
|
||
| address internal _token; | ||
| uint internal _amountToSend; |
Check warning
Code scanning / Slither
State variables that could be declared immutable Warning test
…tion after initProxy in deploy scripts
| function buildOptions( | ||
| uint128 gasLzReceive_, | ||
| uint128 valueLzReceive_, | ||
| uint16 _indexLzCompose, |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
3 participants
Uh oh!
There was an error while loading. Please reload this page.