Skip to content

Commit 180958b

Browse files
ci(release): drop redundant E2E from the orchestrate build path (#461)
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
1 parent 308fd8a commit 180958b

1 file changed

Lines changed: 2 additions & 63 deletions

File tree

.github/workflows/build-cli.yaml

Lines changed: 2 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Build cascade CLI
22
# Called by orchestrate workflow - no direct triggers
33
# Distribution: Use `go install github.com/stablekernel/cascade/cmd/cascade@latest`
4+
# End-to-end coverage is the required PR gate (e2e.yaml); it does not run here.
45
name: Build CLI
56

67
on:
@@ -13,7 +14,7 @@ on:
1314
outputs:
1415
result:
1516
description: 'Build result (success/failure)'
16-
value: ${{ jobs.e2e-tests.result }}
17+
value: ${{ jobs.build.result }}
1718

1819
permissions:
1920
contents: read
@@ -41,65 +42,3 @@ jobs:
4142
./cascade detect-changes --help
4243
./cascade generate-changelog --help
4344
./cascade generate-workflow --help
44-
45-
e2e-tests:
46-
name: E2E Tests
47-
runs-on: ubuntu-latest
48-
needs: [build]
49-
# The act + gitea scenarios run serially (-parallel 1, see the test step),
50-
# which trades wall-clock for reliability, so the job needs more than the
51-
# default headroom. 70m covers the 60m go test budget plus checkout, Go
52-
# install, and container teardown.
53-
timeout-minutes: 70
54-
steps:
55-
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
56-
57-
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6.5.0
58-
with:
59-
# This job runs the e2e module; install the Go it declares so `go test`
60-
# doesn't hard-fail under GOTOOLCHAIN=local. The root build job above
61-
# uses the root go.mod's version (1.25).
62-
go-version-file: e2e/go.mod
63-
cache: true
64-
cache-dependency-path: e2e/go.sum
65-
66-
- name: Widen Docker network address pool
67-
# Each scenario creates its own docker network, and the daemon's
68-
# default address pool is small. Even with synchronous per-scenario
69-
# network teardown, brief cleanup lag under serial load can leave the
70-
# pool short and fail a later scenario at setup with "all predefined
71-
# address pools have been fully subnetted". Carving /24 subnets out of
72-
# a 10.99.0.0/16 base yields 256 networks of headroom, well above the
73-
# handful in flight at once, so cleanup lag can never exhaust the pool.
74-
run: |
75-
sudo mkdir -p /etc/docker
76-
echo '{"default-address-pools":[{"base":"10.99.0.0/16","size":24}]}' | sudo tee /etc/docker/daemon.json
77-
sudo systemctl restart docker
78-
# Wait for the daemon to come back before the tests start.
79-
timeout 60 sh -c 'until docker info >/dev/null 2>&1; do sleep 1; done'
80-
81-
- name: Run E2E tests
82-
working-directory: e2e
83-
# Run scenarios serially (-parallel 1). The 4-core / ~7.9GB runner is
84-
# OOM-killed at 4 (silent FAIL, see #104), and even at 2 the concurrent
85-
# act + gitea container load throttles gitea (405 "try again later") and
86-
# destabilises act runs, producing intermittent failures unrelated to
87-
# the product. Serial execution removes that contention; the longer
88-
# 60m timeout covers the resulting slower wall-clock.
89-
run: go test -v -parallel 1 -timeout 60m ./...
90-
91-
# On a retry-exhausted scenario the harness writes the last attempt's raw
92-
# act stdout/stderr to e2e/_artifacts/<scenario>-attempt<N>.log so the
93-
# stack-trace origin survives the CI log retention window. Upload it on
94-
# every run (always()) so the evidence is recoverable whether the job
95-
# failed or a flake was absorbed. The directory may not exist when no
96-
# scenario exhausted its retries; if-no-files-found: ignore keeps that a
97-
# clean no-op rather than a warning.
98-
- name: Upload e2e crash evidence
99-
if: always()
100-
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
101-
with:
102-
name: e2e-crash-evidence
103-
path: e2e/_artifacts/
104-
if-no-files-found: ignore
105-
retention-days: 14

0 commit comments

Comments
 (0)