Skip to content

Commit 6d6dfdb

Browse files
committed
ci: skip Go cache save on Windows to stop flaky cache-save post-step
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
1 parent 41d55b0 commit 6d6dfdb

4 files changed

Lines changed: 32 additions & 0 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ jobs:
7070
with:
7171
go-version: ${{ matrix.go }}
7272
cache-dependency-path: "**/go.sum"
73+
# Skip the Go cache save on Windows: the tar/zstd cache-save post-step
74+
# flakes intermittently on windows-latest and fails the job even when
75+
# tests pass. Linux and macOS keep caching.
76+
cache: ${{ runner.os != 'Windows' }}
7377
- name: test -race
7478
working-directory: ${{ env.MODULE }}
7579
run: go test -race ./...

.github/workflows/sink.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ jobs:
3737
with:
3838
go-version: ${{ matrix.go }}
3939
cache-dependency-path: "**/go.sum"
40+
# Skip the Go cache save on Windows: the tar/zstd cache-save post-step
41+
# flakes intermittently on windows-latest and fails the job even when
42+
# tests pass. Linux and macOS keep caching.
43+
cache: ${{ runner.os != 'Windows' }}
4044
- name: test -race
4145
shell: bash
4246
run: |
@@ -84,6 +88,10 @@ jobs:
8488
with:
8589
go-version: "1.26.4"
8690
cache-dependency-path: "**/go.sum"
91+
# Skip the Go cache save on Windows: the tar/zstd cache-save post-step
92+
# flakes intermittently on windows-latest and fails the job even when
93+
# tests pass. Linux and macOS keep caching.
94+
cache: ${{ runner.os != 'Windows' }}
8795
- name: test -race
8896
shell: bash
8997
run: go test -C "${{ matrix.module }}" -race ./...
@@ -147,6 +155,10 @@ jobs:
147155
with:
148156
go-version: "1.26.4"
149157
cache-dependency-path: "**/go.sum"
158+
# Skip the Go cache save on Windows: the tar/zstd cache-save post-step
159+
# flakes intermittently on windows-latest and fails the job even when
160+
# tests pass. Linux and macOS keep caching.
161+
cache: ${{ runner.os != 'Windows' }}
150162
- name: integration tests
151163
shell: bash
152164
run: go test -C "${{ matrix.module }}" -tags integration ./...

.github/workflows/source.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ jobs:
3939
with:
4040
go-version: ${{ matrix.go }}
4141
cache-dependency-path: "**/go.sum"
42+
# Skip the Go cache save on Windows: the tar/zstd cache-save post-step
43+
# flakes intermittently on windows-latest and fails the job even when
44+
# tests pass. Linux and macOS keep caching.
45+
cache: ${{ runner.os != 'Windows' }}
4246
- name: test -race
4347
shell: bash
4448
run: |
@@ -73,6 +77,10 @@ jobs:
7377
with:
7478
go-version: "1.26.4"
7579
cache-dependency-path: "**/go.sum"
80+
# Skip the Go cache save on Windows: the tar/zstd cache-save post-step
81+
# flakes intermittently on windows-latest and fails the job even when
82+
# tests pass. Linux and macOS keep caching.
83+
cache: ${{ runner.os != 'Windows' }}
7684
- name: test -race
7785
shell: bash
7886
run: go test -C "${{ matrix.module }}" -race ./...
@@ -119,6 +127,10 @@ jobs:
119127
with:
120128
go-version: "1.26.4"
121129
cache-dependency-path: "**/go.sum"
130+
# Skip the Go cache save on Windows: the tar/zstd cache-save post-step
131+
# flakes intermittently on windows-latest and fails the job even when
132+
# tests pass. Linux and macOS keep caching.
133+
cache: ${{ runner.os != 'Windows' }}
122134
- name: integration tests
123135
shell: bash
124136
run: go test -C "${{ matrix.module }}" -tags integration ./...

.github/workflows/test.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ jobs:
3232
with:
3333
go-version: ${{ matrix.go }}
3434
cache-dependency-path: "**/go.sum"
35+
# Skip the Go cache save on Windows: the tar/zstd cache-save post-step
36+
# flakes intermittently on windows-latest and fails the job even when
37+
# tests pass. Linux and macOS keep caching.
38+
cache: ${{ runner.os != 'Windows' }}
3539
- name: test -race
3640
shell: bash
3741
run: |

0 commit comments

Comments
 (0)