Mlm#1571
Conversation
# Conflicts: # pystac/extensions/mlm.py
# Conflicts: # CHANGELOG.md
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1571 +/- ##
==========================================
+ Coverage 92.31% 92.44% +0.13%
==========================================
Files 55 55
Lines 8403 8604 +201
Branches 973 1045 +72
==========================================
+ Hits 7757 7954 +197
- Misses 458 459 +1
- Partials 188 191 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
pinging @romeokienzler for a code review |
|
@jonas-hurst I'm in for the review - let me take a look! |
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
One minor question, but otherwise LGTM.
| @property | ||
| def mlm(self) -> AssetGeneralMLMExtension[Asset] | AssetDetailedMLMExtension: | ||
| if "mlm:name" in self.stac_object.extra_fields: | ||
| if "mlm:architecture" in self.stac_object.extra_fields: |
There was a problem hiding this comment.
What's the reason for this change? It's not clear to me from reading the extension description why the presence of this field should trigger different behavior.
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
Apologies for the change (@jonas-hurst) but we re-worked how extensions work in #1650. Please update this PR to the new way, e.g. by adding a pyproject.toml ... see existing extensions for an example of how to set it up.
|
I forgot about this PR, my apologies... Let's see when I find the time to do this |
3 participants
Description:
Continuation from #1556
Finally found the time to cherry-pick my added commits to a new branch to make reviewing and merging easier
PR Checklist:
pre-commit run --all-files)pytest)