Add the Multi-Tenant Catalogs Endpoint Extension, for nested catalog support#366
Add the Multi-Tenant Catalogs Endpoint Extension, for nested catalog support#366jonhealy1 wants to merge 50 commits intostac-utils:mainfrom
Conversation
|
It's going to be best to fix the extension so it supports python 3.11 |
…jonhealy1/stac-fastapi-pgstac into stac-fastapi-catalogs-extension
|
This is really close to being reviewable, just need some time to do some qa, documentation. |
|
When For example: In my use case I wanted to use catalogs as access controls for collections. Eg Not sure sure if this behavior is to spec and expected, or specific to this implementation. |
|
Another issue - the The |
@bkanuka There is a glitch here, that needs to be fixed. The parent_ids list should not be returned to the client via an API response. The parent_ids list should only be present in Postgres. |
|
@bkanuka Thanks for the feedback. I have implemented the two suggestions you made. Removing parent_ids from collection responses and fixing/ improving the self link generation. |
|
|
||
| # Optional catalogs route | ||
| ENABLE_CATALOGS_ROUTE = _is_env_flag_enabled("ENABLE_CATALOGS_ROUTE") | ||
| logger.info("ENABLE_CATALOGS_ROUTE is set to %s", ENABLE_CATALOGS_ROUTE) |
There was a problem hiding this comment.
ENABLE_CATALOGS_ROUTE -> ENABLE_CATALOGS_ROUTES ?
There was a problem hiding this comment.
I would prefer singular. It matches what we use if SFEOS. Everything starts from /catalogs so it makes some sense. I think both variations make sense.
There was a problem hiding this comment.
I am good with changing it also.
|
@vincentsarago Thanks for reviewing. I have implemented most of your suggestions - except for the name change. I have also updated the catalogs extension to v0.2.0 which basically just means a separate catalogs transactions class. My thinking is that the catalogs transaction routes will only be implemented when the core transaction extension is enabled. This may be too simplistic, let me know what you think. Additionally I added some documentation to the readme and settings.md. |
Related Issue(s):
Description:
Extension spec: https://github.com/StacLabs/multi-tenant-catalogs
STAC-FastAPI catalogs extension: https://github.com/StacLabs/stac-fastapi-catalogs-extension
PR Checklist:
pre-commithooks pass locallymake test)make docs)