feat: typing ingest lambda and related files, app entry, adjusting types as needed#1087
Merged
Merged
Conversation
…nner not identifying the error typescript file and finding temporary workaround during migration.
…ts. Confirmed using s3-utils.ts passes all tests
…ut input object in test to be a more complete StacItem to pass an expected logic gate
theodorehreuter
commented
Apr 7, 2026
| }, | ||
| "editor.tabSize": 2, | ||
| "files.insertFinalNewline": true, | ||
| "typescript.tsserver.maxTsServerMemory": 4096, |
Collaborator
Author
There was a problem hiding this comment.
temporary as it needs more memory in the mixed memory codebase, will remove on final PR to reduce this allocation once it's all typescript
pjhartzell
requested changes
Apr 7, 2026
pjhartzell
left a comment
pjhartzell
left a comment
Collaborator
There was a problem hiding this comment.
I left a few comments, the most important of which relates to the API app being re-created on each Lambda handler invocation.
theodorehreuter
changed the base branch from
tr/drop-908/type-api-layer
to
main
pjhartzell
approved these changes
Apr 30, 2026
pjhartzell
left a comment
pjhartzell
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking care of those items.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Typing the lambda entry points, index files, and continuing to refine types as necessary for the typescript migration.
Proposed Changes:
PR Checklist: