build(deps): drop deprecated @types/color-convert, fix typecheck#1132
Open
matthewhanson wants to merge 2 commits into
Open
build(deps): drop deprecated @types/color-convert, fix typecheck#1132matthewhanson wants to merge 2 commits into
matthewhanson wants to merge 2 commits into
Conversation
@types/color-convert@3.x is now a deprecated stub ("color-convert
provides its own type definitions, so you do not need this installed"),
which broke typecheck with `TS2688: Cannot find type definition file
for 'color-convert'`. Remove the obsolete @types package and take the
color-convert pin bump.
Replaces #1124.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates npm dependencies to resolve a TypeScript typecheck failure caused by a deprecated stub @types/color-convert package being auto-included via typeRoots.
Changes:
- Remove deprecated
@types/color-convertfromdevDependencies(and lockfile) to preventTS2688failures. - Adjust the
color-convertdependency constraint and updatepackage-lock.jsonaccordingly.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Removes @types/color-convert and updates the color-convert constraint. |
| package-lock.json | Removes @types/color-convert entries and updates the top-level dependency constraint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
58
to
62
| "ansi-styles": "<6.2.4 || >6.2.2", | ||
| "chalk": "<5.6.3 || >5.6.1", | ||
| "color-convert": "<3.1.1 || >3.1.1", | ||
| "color-convert": "<3.1.4 || >3.1.1", | ||
| "color-name": "<2.0.1 || >2.0.1", | ||
| "color-string": "<2.1.1 || >2.1.1", |
Per review: `<3.1.4 || >3.1.1` matches every version (including 3.1.1), defeating the pin. Restore `<3.1.1 || >3.1.1`, which excludes exactly the bad release, consistent with the other single-version exclusion pins. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Addressed Copilot's review: restored the pin to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces dependabot #1124, which failed typecheck.
@types/color-convert@3.0.1is a deprecated stub — its own deprecation notice says "color-convert provides its own type definitions, so you do not need this installed." Because every@types/*package is auto-included viatypeRoots, the empty stub producedTS2688: Cannot find type definition file for 'color-convert'.color-convertis not imported by stac-server source (it's only a pinned transitive), so its types aren't needed at all. This removes@types/color-convertand takes thecolor-convertpin bump.Verification
typecheck✓,lint✓ (full CI on this PR).Closes #1124
🤖 Generated with Claude Code