Skip to content

build(deps-dev): bump prettier-eslint-cli to 9 (with prettier-eslint 17)#1133

Open
matthewhanson wants to merge 1 commit into
mainfrom
chore/bump-prettier-eslint-family
Open

build(deps-dev): bump prettier-eslint-cli to 9 (with prettier-eslint 17)#1133
matthewhanson wants to merge 1 commit into
mainfrom
chore/bump-prettier-eslint-family

Conversation

@matthewhanson

Copy link
Copy Markdown
Member

Summary

Replaces dependabot #1126, which failed at npm install with ERESOLVE.

prettier-eslint-cli@9.2.1 requires prettier-eslint >=17.0.1, but the bump landed alone against prettier-eslint@16.4.2. This bumps the pair together (prettier-eslint → ^17.1.1, prettier-eslint-cli → ^9.2.1); prettier stays ^3.8.4.

Verification

npm install resolves cleanly, typecheck ✓, lint ✓ (full CI on this PR).

Closes #1126

🤖 Generated with Claude Code

prettier-eslint-cli@9 requires prettier-eslint >=17.0.1, so bumping it
alone produced an ERESOLVE peer conflict against prettier-eslint@16.
Bump the pair together.

Replaces #1126.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the dev formatting toolchain by bumping prettier-eslint-cli to v9 and prettier-eslint to v17 to resolve an npm peer dependency conflict (per the linked dependabot failure).

Changes:

  • Bump prettier-eslint from ^16.4.2^17.1.1
  • Bump prettier-eslint-cli from ^8.0.1^9.2.1
  • Refresh package-lock.json to reflect the new dependency graph

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Updates devDependencies to the compatible prettier-eslint / prettier-eslint-cli pair.
package-lock.json Captures the resolved dependency tree for the bumped formatter tooling (incl. new transitive deps).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment on lines 133 to +135
"prettier": "^3.8.4",
"prettier-eslint": "^16.4.2",
"prettier-eslint-cli": "^8.0.1",
"prettier-eslint": "^17.1.1",
"prettier-eslint-cli": "^9.2.1",
@matthewhanson

Copy link
Copy Markdown
Member Author

Re: Copilot's note about transitive Node-engine requirements vs the docs workflow pinning Node 20 — good catch. Rather than touch the workflow here, I've aligned docs.yml to .nvmrc (Node 22) and declared engines.node >=22 in #1134 (got 15 has the hard Node 22 requirement), which covers this PR's looser >=20.19 transitive reqs too. Suggest merging #1134 alongside/before this so all CI is on Node 22. No change needed here.

@matthewhanson matthewhanson mentioned this pull request Jun 20, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants