Skip to content

Commit 2dfb36e

Browse files
committed
remove result as return value as it is now used in calling function
1 parent b404642 commit 2dfb36e

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

rust/operator-binary/src/controller/build/config_map.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,7 @@ pub fn build_rolegroup_config_map(
9898
&Container::Vector,
9999
&mut cm_builder,
100100
&validated_cluster.image,
101-
)
102-
.context(InvalidLoggingConfigSnafu {
103-
cm_name: rolegroup.object_name(),
104-
})?;
101+
);
105102

106103
cm_builder.build().with_context(|_| BuildConfigMapSnafu {
107104
rolegroup: rolegroup.clone(),

rust/operator-binary/src/product_logging.rs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ pub enum Error {
3232
MissingVectorAggregatorAddress,
3333
}
3434

35-
type Result<T, E = Error> = std::result::Result<T, E>;
36-
3735
const LOG_CONFIG_FILE: &str = "log_config.py";
3836
const LOG_FILE: &str = "airflow.py.json";
3937

@@ -45,8 +43,7 @@ pub fn extend_config_map_with_log_config<C, K>(
4543
vector_container: &C,
4644
cm_builder: &mut ConfigMapBuilder,
4745
resolved_product_image: &ResolvedProductImage,
48-
) -> Result<()>
49-
where
46+
) where
5047
C: Clone + Ord + Display,
5148
K: Resource,
5249
{
@@ -76,8 +73,6 @@ where
7673
product_logging::framework::create_vector_config(rolegroup, vector_log_config),
7774
);
7875
}
79-
80-
Ok(())
8176
}
8277

8378
fn create_airflow_config(

0 commit comments

Comments
 (0)