fix: remove loop spamming on response status != 200

Author: maltesander

tests/templates/kuttl/mount-dags-gitsync/dag_metrics.py

@@ -62,27 +62,10 @@ def assert_metric(role, metric):
 
 # Wait for the metrics to be consumed by the statsd-exporter
 time.sleep(5)
-# Test the DAG in a loop. Each time we call the script a new job will be started: we can avoid
-# or minimize this by looping over the check instead.
-iterations = 9
-loop = 0
-while True:
-    try:
-        logging.info(f"Response code: {response.status_code}")
-        assert response.status_code == 200, "DAG run could not be triggered."
-        # Worker is not deployed with the kubernetes executor so retrieve success metric from scheduler
-        # (disable line-break flake checks)
-        if (assert_metric("scheduler", "airflow_scheduler_heartbeat")) and (
-            assert_metric(
-                "scheduler", "airflow_dagrun_duration_success_sparkapp_dag_count"
-            )
-        ):  # noqa: W503, W504
-            break
-        time.sleep(10)
-        loop += 1
-        if loop == iterations:
-            logging.error("Still waiting for metrics. Exiting to start a new loop....")
-            # force re-try of script
-            sys.exit(1)
-    except AssertionError as error:
-        logging.warning(f"Encountered: {error}")
+
+logging.info(f"Response code: {response.status_code}")
+assert response.status_code == 200, "DAG run could not be triggered."
+# Worker is not deployed with the kubernetes executor so retrieve success metric from scheduler
+# (disable line-break flake checks)
+assert_metric("scheduler", "airflow_scheduler_heartbeat")
+assert_metric("scheduler", "airflow_dagrun_duration_success_sparkapp_dag_count")