renamed resource names functions for clarity

Author: adwk67

rust/operator-binary/src/controller/build/resource/config_map.rs

@@ -66,7 +66,7 @@ pub fn build_rolegroup_config_map(
             validated_cluster
                 .object_meta(
                     validated_cluster
-                        .resource_names(role_name, role_group_name)
+                        .role_group_resource_names(role_name, role_group_name)
                         .role_group_config_map()
                         .to_string(),
                     validated_cluster.recommended_labels_for(role_name, role_group_name),

rust/operator-binary/src/controller/build/resource/executor.rs

@@ -100,7 +100,7 @@ pub fn build_executor_template_config_map(
         .affinity(&executor_config.affinity)
         .service_account_name(
             cluster
-                .rbac_resource_names()
+                .cluster_resource_names()
                 .service_account_name()
                 .to_string(),
         )
@@ -156,7 +156,7 @@ pub fn build_executor_template_config_map(
         .context(AddVolumeSnafu)?;
     pb.add_volumes(volumes::create_volumes(
         cluster
-            .resource_names(&executor_role_name(), &executor_role_group_name())
+            .role_group_resource_names(&executor_role_name(), &executor_role_group_name())
             .role_group_config_map()
             .as_ref(),
         &executor_config.logging.product_container,
@@ -167,7 +167,10 @@ pub fn build_executor_template_config_map(
         pb.add_container(build_logging_container(
             resolved_product_image,
             vector_log_config,
-            &cluster.resource_names(&executor_role_name(), &executor_template_role_group_name()),
+            &cluster.role_group_resource_names(
+                &executor_role_name(),
+                &executor_template_role_group_name(),
+            ),
         ));
     }
 

rust/operator-binary/src/controller/build/resource/rbac.rs

@@ -21,7 +21,7 @@ stackable_operator::constant!(NONE_ROLE_GROUP_NAME: RoleGroupName = "none");
 pub fn build_service_account(cluster: &ValidatedCluster) -> ServiceAccount {
     rbac::build_service_account(
         cluster,
-        &cluster.rbac_resource_names(),
+        &cluster.cluster_resource_names(),
         rbac_labels(cluster),
     )
 }
@@ -31,7 +31,7 @@ pub fn build_service_account(cluster: &ValidatedCluster) -> ServiceAccount {
 pub fn build_role_binding(cluster: &ValidatedCluster) -> RoleBinding {
     rbac::build_role_binding(
         cluster,
-        &cluster.rbac_resource_names(),
+        &cluster.cluster_resource_names(),
         rbac_labels(cluster),
     )
 }

rust/operator-binary/src/controller/build/resource/service.rs

@@ -22,7 +22,7 @@ pub fn build_rolegroup_headless_service(
         metadata: cluster
             .object_meta(
                 cluster
-                    .resource_names(&ValidatedCluster::role_name(role), role_group_name)
+                    .role_group_resource_names(&ValidatedCluster::role_name(role), role_group_name)
                     .headless_service_name()
                     .to_string(),
                 cluster.recommended_labels(role, role_group_name),
@@ -51,7 +51,7 @@ pub fn build_rolegroup_metrics_service(
         metadata: cluster
             .object_meta(
                 cluster
-                    .resource_names(&ValidatedCluster::role_name(role), role_group_name)
+                    .role_group_resource_names(&ValidatedCluster::role_name(role), role_group_name)
                     .metrics_service_name()
                     .to_string(),
                 cluster.recommended_labels(role, role_group_name),
@@ -85,7 +85,7 @@ pub fn stateful_set_service_name(
 ) -> Option<String> {
     Some(
         cluster
-            .resource_names(&ValidatedCluster::role_name(role), role_group_name)
+            .role_group_resource_names(&ValidatedCluster::role_name(role), role_group_name)
             .headless_service_name()
             .to_string(),
     )

rust/operator-binary/src/controller/build/resource/statefulset.rs

@@ -116,7 +116,7 @@ pub fn build_server_rolegroup_statefulset(
 
     let mut pb = PodBuilder::new();
     let resource_names = validated_cluster
-        .resource_names(&ValidatedCluster::role_name(airflow_role), role_group_name);
+        .role_group_resource_names(&ValidatedCluster::role_name(airflow_role), role_group_name);
 
     let recommended_object_labels =
         validated_cluster.recommended_labels(airflow_role, role_group_name);
@@ -141,7 +141,7 @@ pub fn build_server_rolegroup_statefulset(
         .affinity(&merged_airflow_config.affinity)
         .service_account_name(
             validated_cluster
-                .rbac_resource_names()
+                .cluster_resource_names()
                 .service_account_name()
                 .to_string(),
         )

rust/operator-binary/src/controller/mod.rs

@@ -328,15 +328,15 @@ impl ValidatedCluster {
 
     /// Type-safe names for the per-cluster RBAC resources: the ServiceAccount shared by all
     /// Pods, its (namespaced) RoleBinding, and the operator-deployed ClusterRole it binds.
-    pub fn rbac_resource_names(&self) -> role_utils::ResourceNames {
+    pub fn cluster_resource_names(&self) -> role_utils::ResourceNames {
         role_utils::ResourceNames {
             cluster_name: self.name.clone(),
             product_name: product_name(),
         }
     }
 
     /// Type-safe names for the resources of a role group.
-    pub fn resource_names(
+    pub fn role_group_resource_names(
         &self,
         role_name: &RoleName,
         role_group_name: &RoleGroupName,