Skip to content

Commit 2366d9e

Browse files
committed
chore: Simplify rule comments
1 parent 9f75202 commit 2366d9e

1 file changed

Lines changed: 12 additions & 20 deletions

File tree

deploy/helm/commons-operator/templates/roles.yaml

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,8 @@ metadata:
66
labels:
77
{{- include "operator.labels" . | nindent 4 }}
88
rules:
9-
# Watch pods to detect expiry annotations and evict them (pod restart controller).
10-
# Watch configmaps and secrets (metadata only) to detect changes that should trigger a
11-
# rolling restart of referencing StatefulSets (StatefulSet restart controller).
12-
# list + watch are sufficient; no individual get calls are made (Controller and
13-
# metadata_watcher use list + watch internally).
9+
# Watch pods to detect and evict expired restart annotations.
10+
# Watch configmaps and secrets to trigger rolling restarts of referencing StatefulSets.
1411
- apiGroups:
1512
- ""
1613
resources:
@@ -20,20 +17,15 @@ rules:
2017
verbs:
2118
- list
2219
- watch
23-
# For automatic cluster domain detection: proxy to the kubelet configz endpoint on the
24-
# operator's own node (name supplied via the downward API) to read the clusterDomain
25-
# setting. Only a direct GET on the named node's proxy subresource is needed - no
26-
# list or watch of nodes is required.
20+
# For automatic cluster domain detection.
2721
- apiGroups:
2822
- ""
2923
resources:
3024
- nodes/proxy
3125
verbs:
3226
- get
33-
# Watch StatefulSets labelled restarter.stackable.tech/enabled=true (list + watch) and
34-
# patch their pod template annotations via Server-Side Apply to trigger rolling restarts
35-
# when referenced ConfigMaps or Secrets change (patch). No get needed: SSA does not
36-
# require a preceding get, and the reflector/watcher covers list + watch.
27+
# Watch and patch StatefulSets (labelled restarter.stackable.tech/enabled=true)
28+
# to trigger rolling restarts when referenced ConfigMaps or Secrets change.
3729
- apiGroups:
3830
- apps
3931
resources:
@@ -42,31 +34,31 @@ rules:
4234
- list
4335
- watch
4436
- patch
45-
# Emit Kubernetes events from both the StatefulSet and Pod restart controllers.
37+
# Emit Kubernetes events from the restart controllers.
4638
- apiGroups:
4739
- events.k8s.io
4840
resources:
4941
- events
5042
verbs:
5143
- create
5244
- patch
53-
# Evict pods whose restarter.stackable.tech/expires-at.* annotation timestamp has been
54-
# reached (pod restart controller). Eviction is a create on the pods/eviction subresource.
45+
# Evict pods whose restarter.stackable.tech/expires-at.* annotation timestamp
46+
# has been reached.
5547
- apiGroups:
5648
- ""
5749
resources:
5850
- pods/eviction
5951
verbs:
6052
- create
61-
# Required to maintain MutatingWebhookConfigurations. The operator needs to do this, as it needs
62-
# to enter e.g. it's generated certificate in the webhooks.
53+
# Required to maintain MutatingWebhookConfigurations with auto-generated and
54+
# rotated webhook certificates.
6355
- apiGroups: [admissionregistration.k8s.io]
6456
resources: [mutatingwebhookconfigurations]
6557
verbs:
6658
- create
6759
- patch
68-
# Required to maintain the CRD. The operator needs to do this, as it needs to enter e.g. it's
69-
# generated certificate in the conversion webhook.
60+
# Required to maintain the CRD with auto-generated and rotated webhook
61+
#certificates.
7062
{{ if .Values.maintenance.customResourceDefinitions.maintain }}
7163
- apiGroups:
7264
- apiextensions.k8s.io

0 commit comments

Comments
 (0)