clippy lints

Author: sbernauer

rust/operator-binary/src/restart_controller/statefulset.rs

@@ -73,6 +73,7 @@ impl ReconcilerError for Error {
     }
 }
 
+#[allow(clippy::type_complexity)]
 pub fn create_context(
     client: Client,
 ) -> (
@@ -350,7 +351,7 @@ async fn reconcile(
                     "spec": {
                         "template": {
                             "metadata": {
-                                "annotations": get_updated_restarter_annotations(&sts, ctx).await?,
+                                "annotations": get_updated_restarter_annotations(sts, ctx).await?,
                             },
                         },
                     },

rust/operator-binary/src/webhook/mod.rs

@@ -21,9 +21,9 @@ pub enum Error {
     CreateWebhookServer { source: WebhookError },
 }
 
-pub async fn create_webhook_server<'a>(
+pub async fn create_webhook_server(
     ctx: Arc<Ctx>,
-    operator_environment: &'a OperatorEnvironmentOptions,
+    operator_environment: &OperatorEnvironmentOptions,
     disable_restarter_mutating_webhook: bool,
     client: Client,
 ) -> Result<WebhookServer, Error> {

rust/operator-binary/src/webhook/restarter_mutate_sts.rs

@@ -100,7 +100,7 @@ pub async fn add_sts_restarter_annotation(
         })
     });
 
-    let annotations = match get_updated_restarter_annotations(&sts, ctx).await {
+    let annotations = match get_updated_restarter_annotations(sts, ctx).await {
         Ok(annotations) => annotations,
         Err(err) => {
             return AdmissionResponse::invalid(format!(
@@ -129,9 +129,9 @@ pub async fn add_sts_restarter_annotation(
     {
         Ok(response) => response,
         Err(err) => {
-            return AdmissionResponse::invalid(format!(
+            AdmissionResponse::invalid(format!(
                 "failed to add patch to AdmissionResponse: {err:#}"
-            ));
+            ))
         }
     }
 }