Skip to content

Commit 248c866

Browse files
authored
fix(jupyterhub-keycloak): Don't quote CPU amount (#434)
1 parent 6753e8e commit 248c866

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

stacks/jupyterhub-keycloak/jupyterhub.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,12 @@ options:
203203
"{{cpu}}":
204204
display_name: "{{cpu}}"
205205
kubespawner_override:
206-
cpu_guarantee: "{{cpu}}"
207-
cpu_limit: "{{cpu}}"
206+
# We cannot quote these values because both fields MUST be a float, not a string.
207+
# The Kubernetes notation (eg. 500m) is also not supported.
208+
# See https://github.com/jupyterhub/helm-chart/issues/69
209+
# This leads to this file being skipped in the Helm Chart bump script. Beware!
210+
cpu_guarantee: {{cpu}}
211+
cpu_limit: {{cpu}}
208212
# {% endfor %}
209213
memory:
210214
display_name: Memory

0 commit comments

Comments
 (0)