Skip to content

Commit 7cba7fa

Browse files
maltesanderadwk67
andauthored
Apply suggestions from code review
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
1 parent c651590 commit 7cba7fa

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

docs/modules/demos/pages/argo-cd-git-ops.adoc

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -252,11 +252,13 @@ image::argo-cd-git-ops/airflow-welcome-page.png[]
252252

253253
=== Start the DAG
254254

255-
The `date_demo` DAG can be started by moving the slider and trigger the DAG runs. The DAG itself can be inspected by clicking on it.
255+
The `date_demo` DAG can be started by moving the slider and trigger the DAG runs.
256+
The DAG itself can be inspected by clicking on it.
256257

257258
=== Inspect the DAG
258259

259-
The overview displays details about the DAG runs, durations and other metadata. The graph, code or events can be selected in the tabs for more details.
260+
The overview displays details about the DAG runs, durations and other metadata.
261+
The graph, code or events can be selected in the tabs for more details.
260262

261263
image::argo-cd-git-ops/airflow-dag-overview.png[]
262264

@@ -271,8 +273,9 @@ In the logs, the output of the DAG is printed under a line containing `Output:`,
271273

272274
== Minio
273275

274-
Since the Airflow Kubernetes Executor will be deleted after its run, the logs are written to an S3 bucket. When accessing the logs via the Airflow webserver,
275-
the logs are fetched from S3 instead of the (already deleted) executor pods. The Minio / S3 instance can be accessed via port-forward:
276+
Since the Airflow Kubernetes Executor will be deleted after its run, the logs are written to an S3 bucket.
277+
When accessing the logs via the Airflow webserver, the logs are fetched from S3 instead of the (already deleted) executor pods.
278+
The Minio / S3 instance can be accessed via port-forward:
276279

277280
[source,console]
278281
----
@@ -295,7 +298,7 @@ This demo illustrates the combination of ArgoCD and Stackable, using the full po
295298

296299
// TODO: extend...
297300

298-
As a last step, in order to synchronize changes made to manifests or secrets from the Git repository, the following paragraph demonstrates on how to run this demo on a forked GitHub repository.
301+
The last step is to demonstrate synchronizing changes made to manifests or secrets from the Git repository (to do this the demo is run on a forked GitHub repository).
299302

300303
[#interact-with-git-repository]
301304
== How to interact with ArgoCD, Airflow and the Git repository

0 commit comments

Comments
 (0)