Skip to content

fix: Processing URL and namespace replacement #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Techassi merged 2 commits into from
Jul 10, 2026
Merged

fix: Processing URL and namespace replacement #428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
806be61
fix: Processing URL and namespace replacement
adwk67 Jul 10, 2026
3486ffd
improved comment
adwk67 Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .scripts/update_refs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ echo "$MESSAGE"
# shellcheck disable=SC2016 # We intentionally don't want to expand the variable.
find demos stacks -type f \
-exec grep --color=always -l githubusercontent {} \; \
-exec sed -i -E 's#(stackabletech/demos)/main/#\1/\${UPDATE_BRANCH_REF}/#' {} \; \
-exec sed -i -E 's#(stackabletech/demos)/(refs/heads/)?main/#\1/\${UPDATE_BRANCH_REF}/#' {} \; \
| prepend "\t"

# Now, for all modified files, we can use envsubst
Expand Down
9 changes: 5 additions & 4 deletions demos/signal-processing/create-nifi-ingestion-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,13 @@ data:
service_login(username=USERNAME, password=PASSWORD)
print("Logged in")

# This file path needs adjustment for versioned demos on release branch
response = requests.get("https://raw.githubusercontent.com/stackabletech/demos/refs/heads/main/demos/signal-processing/DownloadAndWriteToDB.json")
# This URL must keep the "stackabletech/demos/main/" form (not "refs/heads/main") so that
Comment thread
Techassi marked this conversation as resolved.
Outdated
# .scripts/update_refs.sh can rewrite it to the release branch at release time.
response = requests.get("https://raw.githubusercontent.com/stackabletech/demos/main/demos/signal-processing/DownloadAndWriteToDB.json")

filename = "/tmp/DownloadAndWriteToDB.json"
with open(filename, "wb") as f:
f.write(response.content)
with open(filename, "w") as f:
f.write(response.text.replace("{{ NAMESPACE }}", os.environ["NAMESPACE"]))

pg_id = get_root_pg_id()

Expand Down
Loading