chore(boil): Simplify tag used for cache

Author: Techassi

rust/boil/src/core/bakefile.rs

@@ -365,12 +365,11 @@ impl Bakefile {
                             &image_name,
                         );
 
-                        let cache_image_index_manifest_tag =
-                            utils::format_image_cache_index_manifest_tag(
-                                &image_version,
-                                &metadata.vendor_tag_prefix,
-                                &cli_args.image_version,
-                            );
+                        let cache_image_index_manifest_tag = utils::format_image_index_manifest_tag(
+                            &image_version,
+                            &metadata.vendor_tag_prefix,
+                            &cli_args.image_version,
+                        );
 
                         let cache_image_manifest_tag = utils::format_image_manifest_tag(
                             &cache_image_index_manifest_tag,

rust/boil/src/utils.rs

@@ -43,16 +43,6 @@ pub fn format_image_index_manifest_tag(
     format!("{image_version}-{vendor_tag_prefix}{vendor_image_version}")
 }
 
-pub fn format_image_cache_index_manifest_tag(
-    image_version: &str,
-    vendor_tag_prefix: &str,
-    vendor_image_version: &str,
-) -> String {
-    let tag =
-        format_image_index_manifest_tag(image_version, vendor_tag_prefix, vendor_image_version);
-    format!("{tag}-cache")
-}
-
 /// Formats and returns the image manifest tag, eg. `1.4.2-stackable25.7.0-amd64`.
 ///
 /// The `strip_architecture` parameter controls if the architecture is included in the tag.
@@ -69,6 +59,8 @@ pub fn format_image_manifest_tag(
     }
 }
 
+// TODO (@Techassi): Can we design this better? Maybe add a new struct/type which implements a bunch
+// of associated functions.
 #[allow(clippy::too_many_arguments)]
 pub fn format_image_tag_parts(
     image_registry: &HostPort,