fix: automatically determine NiFi version create reporting task script (#1189)

* fix: determine nifi version in nifi 1 create reporting task script

* chore: changelog

* chore: formatting

Author: dervoeti

CHANGELOG.md

@@ -114,6 +114,7 @@ All notable changes to this project will be documented in this file.
 - hive: Patch for postgres CVE-2024-1597 ([#1100]).
 - bump image-tools (for `bake`) and nixpkgs (for `nodejs_20`, used by pre-commit) ([#1100]).
 - bump image-tools (for `bake`) to fix `RELEASE` arg ([#1188]).
+- nifi: automatically determine NiFi version create reporting task script ([#1189]).
 
 ### Removed
 
@@ -211,6 +212,7 @@ All notable changes to this project will be documented in this file.
 [#1184]: https://github.com/stackabletech/docker-images/pull/1184
 [#1185]: https://github.com/stackabletech/docker-images/pull/1185
 [#1188]: https://github.com/stackabletech/docker-images/pull/1188
+[#1189]: https://github.com/stackabletech/docker-images/pull/1189
 
 ## [25.3.0] - 2025-03-21
 

nifi/python/create_nifi_reporting_task.py

@@ -47,16 +47,19 @@ def find_reporting_task(name: str, port: str):
     return None
 
 
-def create_reporting_task(name: str, port: str, version: str):
+def create_reporting_task(name: str, port: str):
     """Create a ReportingTask"""
+    nifi_version = nipyapi.system.get_system_diagnostics().system_diagnostics.aggregate_snapshot.version_info.ni_fi_version
     task = nipyapi.nifi.models.reporting_task_entity.ReportingTaskEntity(
         revision=nipyapi.nifi.models.revision_dto.RevisionDTO(version=0),
         disconnected_node_acknowledged=False,
         component=nipyapi.nifi.models.reporting_task_dto.ReportingTaskDTO(
             name=name,
             type="org.apache.nifi.reporting.prometheus.PrometheusReportingTask",
             bundle=nipyapi.nifi.models.bundle_dto.BundleDTO(
-                group="org.apache.nifi", artifact="nifi-prometheus-nar", version=version
+                group="org.apache.nifi",
+                artifact="nifi-prometheus-nar",
+                version=nifi_version,
             ),
             properties={
                 "prometheus-reporting-task-metrics-endpoint-port": port,
@@ -158,9 +161,7 @@ def main():
     reporting_task = find_reporting_task(name=task_name, port=port)
 
     if reporting_task is None:
-        reporting_task = create_reporting_task(
-            name=task_name, port=port, version=args["nifi_version"]
-        )
+        reporting_task = create_reporting_task(name=task_name, port=port)
         print(
             get_reporting_task_name(task=reporting_task)
             + " [%s] -> CREATED" % reporting_task.id