Skip to content

Commit 5b12040

Browse files
authored
fix(superset): Add patch to pin the sax package to 1.2.4 (#1363)
* fix(superset): Add patch to pin the sax package to 1.2.4 * chore(superset): Update first patch file Apparently my version of git dropped the last character of both commit IDs. This might be a thing to investigate down the line.
1 parent ee6ea4b commit 5b12040

4 files changed

Lines changed: 64 additions & 2 deletions

File tree

superset/stackable/patches/4.1.2/0001-fix-pin-luxon-to-fix-build.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ For some reason npm tries to use a newer version of luxon than the version in th
99
1 file changed, 1 insertion(+), 1 deletion(-)
1010

1111
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
12-
index ebca197a25..bb2641a67f 100644
12+
index ebca197a2..bb2641a67 100644
1313
--- a/superset-frontend/package.json
1414
+++ b/superset-frontend/package.json
1515
@@ -148,7 +148,7 @@
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
From bfb1e27ad0c7736d4db12a9901f8c73c5f7f4461 Mon Sep 17 00:00:00 2001
2+
From: Techassi <git@techassi.dev>
3+
Date: Tue, 16 Dec 2025 10:01:19 +0100
4+
Subject: pin sax to 1.2.4
5+
6+
This is a similar issue to what we already discovered in #1315
7+
and #1316. For more details, see the linked PRs.
8+
---
9+
superset-frontend/package.json | 5 +++--
10+
1 file changed, 3 insertions(+), 2 deletions(-)
11+
12+
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
13+
index bb2641a67..8271aece2 100644
14+
--- a/superset-frontend/package.json
15+
+++ b/superset-frontend/package.json
16+
@@ -365,11 +365,12 @@
17+
"ansi-regex": "^4.1.1"
18+
},
19+
"puppeteer": "^22.4.1",
20+
- "@types/react": "^16.9.53"
21+
+ "@types/react": "^16.9.53",
22+
+ "sax": "1.2.4"
23+
},
24+
"readme": "ERROR: No README data found!",
25+
"scarfSettings": {
26+
"allowTopLevel": true
27+
},
28+
"_id": "superset@0.0.0-dev"
29+
-}
30+
+}
31+
\ No newline at end of file

superset/stackable/patches/4.1.4/0001-fix-pin-luxon-to-fix-build.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ For some reason npm tries to use a newer version of luxon than the version in th
99
1 file changed, 1 insertion(+), 1 deletion(-)
1010

1111
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
12-
index 066ce89764..cd6ca2a53f 100644
12+
index 066ce8976..cd6ca2a53 100644
1313
--- a/superset-frontend/package.json
1414
+++ b/superset-frontend/package.json
1515
@@ -148,7 +148,7 @@
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
From 782c0d5b814d3095668b2c01244e84463d507915 Mon Sep 17 00:00:00 2001
2+
From: Techassi <git@techassi.dev>
3+
Date: Tue, 16 Dec 2025 10:01:19 +0100
4+
Subject: pin sax to 1.2.4
5+
6+
This is a similar issue to what we already discovered in #1315
7+
and #1316. For more details, see the linked PRs.
8+
---
9+
superset-frontend/package.json | 5 +++--
10+
1 file changed, 3 insertions(+), 2 deletions(-)
11+
12+
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
13+
index cd6ca2a53..0f59fff60 100644
14+
--- a/superset-frontend/package.json
15+
+++ b/superset-frontend/package.json
16+
@@ -365,11 +365,12 @@
17+
"ansi-regex": "^4.1.1"
18+
},
19+
"puppeteer": "^22.4.1",
20+
- "@types/react": "^16.9.53"
21+
+ "@types/react": "^16.9.53",
22+
+ "sax": "1.2.4"
23+
},
24+
"readme": "ERROR: No README data found!",
25+
"scarfSettings": {
26+
"allowTopLevel": true
27+
},
28+
"_id": "superset@0.0.0-dev"
29+
-}
30+
+}
31+
\ No newline at end of file

0 commit comments

Comments
 (0)