Add --no-log-init to useradd call (#781)

* Move base image to new heredoc format

There are no functional changes

* Add --no-log-init to useradd call

This is to work around a bug in Go/Docker when large user ids are used and is in preparation of further security relevant changes where we are going to change the default user id

* Hadolint

* Hadolint

* Remove explicit creation of home directory as useradd will create it already

* useradd now creates home directory as well

better formatting of command

Author: lfrancke

stackable-base/Dockerfile

@@ -90,16 +90,32 @@ microdnf install \
   nano \
   tar
 
+###
+### Add Stackable user and group
+###
 # Added only temporarily to create the user and group, removed again below
 microdnf install shadow-utils
 groupadd --gid 1000 --system stackable
-useradd --gid stackable --uid 1000 --system stackable -d /stackable
 
-mkdir /stackable
-chown stackable:stackable /stackable
+# The --no-log-init is required to work around a bug/problem in Go/Docker when very large UIDs are used
+# See https://github.com/moby/moby/issues/5419#issuecomment-41478290 for more context
+# Making this a system user prevents a mail dir from being created, expiry of passwords etc. but it will warn:
+#   useradd warning: stackable's uid 1000 is greater than SYS_UID_MAX 999
+# We can safely ignore this warning, to get rid of the warning we could change /etc/login.defs but that does not seem worth it
+useradd \
+  --no-log-init \
+  --gid stackable \
+  --uid 1000 \
+  --system \
+  --create-home \
+  --home-dir /stackable \
+   stackable
 microdnf remove shadow-utils
 microdnf clean all
 
+###
+### Make shell usage in our containers "nicer"
+###
 {
   echo "alias ll='ls -alF --color=auto'"
   echo "alias ls='ls --color=auto'"